archive mirror
 help / color / mirror / Atom feed
* [PATCH] media: v4l2-pci-skeleton: Remove usage of the deprecated "pci-dma-compat.h" API
@ 2021-08-29  9:52 Christophe JAILLET
  0 siblings, 0 replies; only message in thread
From: Christophe JAILLET @ 2021-08-29  9:52 UTC (permalink / raw)
  To: mchehab+huawei; +Cc: linux-kernel, kernel-janitors, Christophe JAILLET

In [1], Christoph Hellwig has proposed to remove the wrappers in

Some reasons why this API should be removed have been given by Julia
Lawall in [2].

A coccinelle script has been used to perform the needed transformation
Only relevant parts are given below.

expression e1, e2;
-    pci_set_dma_mask(e1, e2)
+    dma_set_mask(&e1->dev, e2)


Signed-off-by: Christophe JAILLET <>
It has been compile tested. is not really helpful for this patch. I've picked up what made
sense to me from previous commit.
 samples/v4l/v4l2-pci-skeleton.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/samples/v4l/v4l2-pci-skeleton.c b/samples/v4l/v4l2-pci-skeleton.c
index 3fa6582b4a68..6311b7465220 100644
--- a/samples/v4l/v4l2-pci-skeleton.c
+++ b/samples/v4l/v4l2-pci-skeleton.c
@@ -766,7 +766,7 @@ static int skeleton_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 	ret = pci_enable_device(pdev);
 	if (ret)
 		return ret;
-	ret = pci_set_dma_mask(pdev, DMA_BIT_MASK(32));
+	ret = dma_set_mask(&pdev->dev, DMA_BIT_MASK(32));
 	if (ret) {
 		dev_err(&pdev->dev, "no suitable DMA available.\n");
 		goto disable_pci;

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-08-29  9:52 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-29  9:52 [PATCH] media: v4l2-pci-skeleton: Remove usage of the deprecated "pci-dma-compat.h" API Christophe JAILLET

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).