From: Thomas Gleixner <tglx@linutronix.de>
To: Julia Lawall <julia.lawall@inria.fr>, Joe Perches <joe@perches.com>
Cc: "Giuseppe Scrivano" <gscrivan@redhat.com>,
"Valdis Klētnieks" <valdis.kletnieks@vt.edu>,
kernelnewbies <kernelnewbies@kernelnewbies.org>,
kernel-janitors <kernel-janitors@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
"Andy Whitcroft" <apw@shadowen.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
linux-kernel-mentees@lists.linuxfoundation.org,
cocci <cocci@systeme.lip6.fr>
Subject: Re: [Cocci] coccinelle: Convert comma to semicolons (was Re: [PATCH] checkpatch: Add test for comma
Date: Thu, 24 Sep 2020 20:19:03 +0000 [thread overview]
Message-ID: <87tuvn6i88.fsf@nanos.tec.linutronix.de> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2008220905460.3150@hadrien>
On Sat, Aug 22 2020 at 09:07, Julia Lawall wrote:
> On Fri, 21 Aug 2020, Joe Perches wrote:
>> True enough for a general statement, though the coccinelle
>> script Julia provided does not change a single instance of
>> for loop expressions with commas.
>>
>> As far as I can tell, no logic defect is introduced by the
>> script at all.
>
> The script has a rule to ensure that what is changed is part of a top
> level statement that has the form e1, e2;. I put that in to avoid
> transforming cases where the comma is the body of a macro, but it protects
> against for loop headers as well.
Right. I went through the lot and did not find something dodgy. Except
for two hunks this still applies. Can someone please send a proper patch
with changelog/SOB etc. for this?
And of course that script really wants to be part of the kernel cocci
checks to catch further instances.
Thanks,
tglx
next prev parent reply other threads:[~2020-09-24 20:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200818184107.f8af232fb58b17160c570874@linux-foundation.org>
[not found] ` <3bf27caf462007dfa75647b040ab3191374a59de.camel@perches.com>
[not found] ` <b0fd63e4b379eda69ee85ab098353582b8c054bb.camel@perches.com>
[not found] ` <alpine.DEB.2.22.394.2008201021400.2524@hadrien>
[not found] ` <a5713d8597065ef986f780499428fcc4cd31c003.camel@perches.com>
[not found] ` <alpine.DEB.2.22.394.2008201856110.2524@hadrien>
2020-08-22 1:08 ` [Cocci] coccinelle: Convert comma to semicolons (was Re: [PATCH] checkpatch: Add test for comma Joe Perches
2020-08-22 3:35 ` Valdis Klētnieks
2020-08-22 5:30 ` Joe Perches
2020-08-22 7:07 ` Julia Lawall
2020-09-24 20:19 ` Thomas Gleixner [this message]
2020-09-24 20:21 ` Julia Lawall
2020-09-24 20:33 ` Joe Perches
2020-09-24 21:53 ` Thomas Gleixner
2020-09-24 22:23 ` Joe Perches
2020-09-25 17:06 ` Julia Lawall
2020-09-25 17:26 ` Joe Perches
2020-09-26 19:11 ` Valdis Klētnieks
2020-09-27 17:08 ` Julia Lawall
2020-09-27 17:45 ` Joe Perches
2020-09-27 19:35 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tuvn6i88.fsf@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=akpm@linux-foundation.org \
--cc=apw@shadowen.org \
--cc=cocci@systeme.lip6.fr \
--cc=gscrivan@redhat.com \
--cc=joe@perches.com \
--cc=julia.lawall@inria.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=kernelnewbies@kernelnewbies.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=valdis.kletnieks@vt.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).