* [PATCH] xen/events: remove redundant initialization of variable irq
@ 2021-07-21 11:40 Colin King
2021-07-21 15:36 ` Juergen Gross
0 siblings, 1 reply; 3+ messages in thread
From: Colin King @ 2021-07-21 11:40 UTC (permalink / raw)
To: Boris Ostrovsky, Juergen Gross, Stefano Stabellini, xen-devel
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The variable irq is being initialized with a value that is never
read, it is being updated later on. The assignment is redundant and
can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/xen/events/events_base.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/xen/events/events_base.c b/drivers/xen/events/events_base.c
index d7e361fb0548..154daddbdcb4 100644
--- a/drivers/xen/events/events_base.c
+++ b/drivers/xen/events/events_base.c
@@ -1009,7 +1009,7 @@ static void __unbind_from_irq(unsigned int irq)
int xen_bind_pirq_gsi_to_irq(unsigned gsi,
unsigned pirq, int shareable, char *name)
{
- int irq = -1;
+ int irq;
struct physdev_irq irq_op;
int ret;
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] xen/events: remove redundant initialization of variable irq
2021-07-21 11:40 [PATCH] xen/events: remove redundant initialization of variable irq Colin King
@ 2021-07-21 15:36 ` Juergen Gross
2021-07-21 19:23 ` Boris Ostrovsky
0 siblings, 1 reply; 3+ messages in thread
From: Juergen Gross @ 2021-07-21 15:36 UTC (permalink / raw)
To: Colin King, Boris Ostrovsky, Stefano Stabellini, xen-devel
Cc: kernel-janitors, linux-kernel
[-- Attachment #1.1.1: Type: text/plain, Size: 416 bytes --]
On 21.07.21 13:40, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The variable irq is being initialized with a value that is never
> read, it is being updated later on. The assignment is redundant and
> can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Juergen
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3135 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xen/events: remove redundant initialization of variable irq
2021-07-21 15:36 ` Juergen Gross
@ 2021-07-21 19:23 ` Boris Ostrovsky
0 siblings, 0 replies; 3+ messages in thread
From: Boris Ostrovsky @ 2021-07-21 19:23 UTC (permalink / raw)
To: Juergen Gross, Colin King, Stefano Stabellini, xen-devel
Cc: kernel-janitors, linux-kernel
On 7/21/21 11:36 AM, Juergen Gross wrote:
> On 21.07.21 13:40, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> The variable irq is being initialized with a value that is never
>> read, it is being updated later on. The assignment is redundant and
>> can be removed.
>>
>> Addresses-Coverity: ("Unused value")
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> Reviewed-by: Juergen Gross <jgross@suse.com>
Applied to for-linus-5.14
-boris
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-07-21 19:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-21 11:40 [PATCH] xen/events: remove redundant initialization of variable irq Colin King
2021-07-21 15:36 ` Juergen Gross
2021-07-21 19:23 ` Boris Ostrovsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).