* [PATCH] staging: vc04_services: Delete unnecessary NULL check
@ 2024-04-24 11:43 Dan Carpenter
2024-04-24 15:17 ` Stefan Wahren
2024-04-25 6:37 ` Umang Jain
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2024-04-24 11:43 UTC (permalink / raw)
To: Florian Fainelli
Cc: Broadcom internal kernel review list, Greg Kroah-Hartman,
Umang Jain, Stefan Wahren, linux-rpi-kernel, linux-arm-kernel,
linux-staging, linux-kernel, kernel-janitors
The "state" pointer points to an offset in the middle of the "mgmt"
struct so it can't possibly be NULL. And also we dereferenced it on the
line before. So this NULL check is pointless. Delete it.
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
.../staging/vc04_services/interface/vchiq_arm/vchiq_dev.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_dev.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_dev.c
index 9fe35864936c..3c63347d2d08 100644
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_dev.c
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_dev.c
@@ -1170,11 +1170,6 @@ static int vchiq_open(struct inode *inode, struct file *file)
dev_dbg(state->dev, "arm: vchiq open\n");
- if (!state) {
- dev_err(state->dev, "arm: vchiq has no connection to VideoCore\n");
- return -ENOTCONN;
- }
-
instance = kzalloc(sizeof(*instance), GFP_KERNEL);
if (!instance)
return -ENOMEM;
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: vc04_services: Delete unnecessary NULL check
2024-04-24 11:43 [PATCH] staging: vc04_services: Delete unnecessary NULL check Dan Carpenter
@ 2024-04-24 15:17 ` Stefan Wahren
2024-04-25 6:37 ` Umang Jain
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Wahren @ 2024-04-24 15:17 UTC (permalink / raw)
To: Dan Carpenter, Florian Fainelli
Cc: Broadcom internal kernel review list, Greg Kroah-Hartman,
Umang Jain, linux-rpi-kernel, linux-arm-kernel, linux-staging,
linux-kernel, kernel-janitors
Am 24.04.24 um 13:43 schrieb Dan Carpenter:
> The "state" pointer points to an offset in the middle of the "mgmt"
> struct so it can't possibly be NULL. And also we dereferenced it on the
> line before. So this NULL check is pointless. Delete it.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Stefan Wahren <wahrenst@gmx.net>
Thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: vc04_services: Delete unnecessary NULL check
2024-04-24 11:43 [PATCH] staging: vc04_services: Delete unnecessary NULL check Dan Carpenter
2024-04-24 15:17 ` Stefan Wahren
@ 2024-04-25 6:37 ` Umang Jain
1 sibling, 0 replies; 3+ messages in thread
From: Umang Jain @ 2024-04-25 6:37 UTC (permalink / raw)
To: Dan Carpenter, Florian Fainelli
Cc: Broadcom internal kernel review list, Greg Kroah-Hartman,
Stefan Wahren, linux-rpi-kernel, linux-arm-kernel, linux-staging,
linux-kernel, kernel-janitors
HI Dan,
Thank you for the patch
On 24/04/24 5:13 pm, Dan Carpenter wrote:
> The "state" pointer points to an offset in the middle of the "mgmt"
> struct so it can't possibly be NULL. And also we dereferenced it on the
> line before. So this NULL check is pointless. Delete it.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>
> ---
> .../staging/vc04_services/interface/vchiq_arm/vchiq_dev.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_dev.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_dev.c
> index 9fe35864936c..3c63347d2d08 100644
> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_dev.c
> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_dev.c
> @@ -1170,11 +1170,6 @@ static int vchiq_open(struct inode *inode, struct file *file)
>
> dev_dbg(state->dev, "arm: vchiq open\n");
>
> - if (!state) {
> - dev_err(state->dev, "arm: vchiq has no connection to VideoCore\n");
> - return -ENOTCONN;
> - }
> -
> instance = kzalloc(sizeof(*instance), GFP_KERNEL);
> if (!instance)
> return -ENOMEM;
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-04-25 6:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-24 11:43 [PATCH] staging: vc04_services: Delete unnecessary NULL check Dan Carpenter
2024-04-24 15:17 ` Stefan Wahren
2024-04-25 6:37 ` Umang Jain
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).