* [PATCH] Bluetooth: hci_uart: Remove redundant assignment to fw_ptr
@ 2021-06-16 19:45 Nigel Christian
2021-06-26 5:53 ` Marcel Holtmann
0 siblings, 1 reply; 2+ messages in thread
From: Nigel Christian @ 2021-06-16 19:45 UTC (permalink / raw)
To: Marcel Holtmann, Johan Hedberg, Luiz Augusto von Dentz
Cc: linux-bluetooth, kernel-janitors
The variable fw_ptr is assigned a value that is not read and the same value
is assigned in the patch goto. The assignment is redundant and can be
removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Nigel Christian <nigel.l.christian@gmail.com>
---
drivers/bluetooth/hci_ag6xx.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/bluetooth/hci_ag6xx.c b/drivers/bluetooth/hci_ag6xx.c
index 1f55df93e4ce..2d40302409ff 100644
--- a/drivers/bluetooth/hci_ag6xx.c
+++ b/drivers/bluetooth/hci_ag6xx.c
@@ -199,7 +199,6 @@ static int ag6xx_setup(struct hci_uart *hu)
fwname, err);
goto patch;
}
- fw_ptr = fw->data;
bt_dev_info(hdev, "Applying bddata (%s)", fwname);
--
2.31.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] Bluetooth: hci_uart: Remove redundant assignment to fw_ptr
2021-06-16 19:45 [PATCH] Bluetooth: hci_uart: Remove redundant assignment to fw_ptr Nigel Christian
@ 2021-06-26 5:53 ` Marcel Holtmann
0 siblings, 0 replies; 2+ messages in thread
From: Marcel Holtmann @ 2021-06-26 5:53 UTC (permalink / raw)
To: Nigel Christian
Cc: Johan Hedberg, Luiz Augusto von Dentz,
Bluetooth Kernel Mailing List, kernel-janitors
Hi Nigel,
> The variable fw_ptr is assigned a value that is not read and the same value
> is assigned in the patch goto. The assignment is redundant and can be
> removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Nigel Christian <nigel.l.christian@gmail.com>
> ---
> drivers/bluetooth/hci_ag6xx.c | 1 -
> 1 file changed, 1 deletion(-)
patch has been applied to bluetooth-next tree.
Regards
Marcel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-26 5:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-16 19:45 [PATCH] Bluetooth: hci_uart: Remove redundant assignment to fw_ptr Nigel Christian
2021-06-26 5:53 ` Marcel Holtmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).