kernel-janitors.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH 1/2] kunit: unregister the device on error
       [not found] <20240418131754.58217-2-wander@redhat.com>
@ 2024-04-18 15:00 ` Markus Elfring
  2024-04-18 15:21   ` Wander Lairson Costa
  0 siblings, 1 reply; 2+ messages in thread
From: Markus Elfring @ 2024-04-18 15:00 UTC (permalink / raw)
  To: Wander Lairson Costa, kunit-dev, linux-kselftest,
	kernel-janitors, Brendan Higgins, David Gow, Rae Moar
  Cc: LKML

> kunit_init_device() should unregister the device on bus register error.

* Would another imperative wording be desirable also for this change description?

* Will the tag “Fixes” become relevant here?

Regards,
Markus

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH 1/2] kunit: unregister the device on error
  2024-04-18 15:00 ` [PATCH 1/2] kunit: unregister the device on error Markus Elfring
@ 2024-04-18 15:21   ` Wander Lairson Costa
  0 siblings, 0 replies; 2+ messages in thread
From: Wander Lairson Costa @ 2024-04-18 15:21 UTC (permalink / raw)
  To: Markus Elfring
  Cc: kunit-dev, linux-kselftest, kernel-janitors, Brendan Higgins,
	David Gow, Rae Moar, LKML

On Thu, Apr 18, 2024 at 12:06 PM Markus Elfring <Markus.Elfring@web.de> wrote:
>
> > kunit_init_device() should unregister the device on bus register error.
>


> * Would another imperative wording be desirable also for this change description?

It makes sense, I will change the comment description.

>
> * Will the tag “Fixes” become relevant here?

I often forget this tag. I will add it.

>
> Regards,
> Markus
>


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-04-18 15:21 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20240418131754.58217-2-wander@redhat.com>
2024-04-18 15:00 ` [PATCH 1/2] kunit: unregister the device on error Markus Elfring
2024-04-18 15:21   ` Wander Lairson Costa

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).