[PATCH][next] gpiolib: remove redundant initialization of pointer desc

* [PATCH][next] gpiolib: remove redundant initialization of pointer desc
@ 2018-01-16 11:56 Colin King
  2018-01-16 23:19 ` Linus Walleij
  0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2018-01-16 11:56 UTC (permalink / raw)
  To: Linus Walleij, linux-gpio; +Cc: kernel-janitors, linux-kernel

From: Colin Ian King <colin.king@canonical.com>

The initialized value stored in pointer desc is never read as it
is updated in the first executable statement in the function.
This is therefore redundant and can be removed.

Cleans up clang warning:
drivers/gpio/gpiolib.c:3710:20: warning: Value stored to 'desc'
during its initialization is never read

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/gpio/gpiolib.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index 39a0144d5be5..b4c833b3d4e0 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -3707,7 +3707,7 @@ struct gpio_desc *gpiod_get_from_of_node(struct device_node *node,
 					 enum gpiod_flags dflags,
 					 const char *label)
 {
-	struct gpio_desc *desc = ERR_PTR(-ENODEV);
+	struct gpio_desc *desc;
 	unsigned long lflags = 0;
 	enum of_gpio_flags flags;
 	bool active_low = false;
-- 
2.15.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread