* [PATCH][next] drm/amd/display: fix spelling mistake "exeuction" -> "execution"
@ 2019-11-09 19:49 Colin King
2019-11-11 13:37 ` Kazlauskas, Nicholas
` (3 more replies)
0 siblings, 4 replies; 10+ messages in thread
From: Colin King @ 2019-11-09 19:49 UTC (permalink / raw)
To: Harry Wentland, Leo Li, Alex Deucher, Christian König,
David Zhou, David Airlie, Daniel Vetter, amd-gfx, dri-devel
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
There are spelling mistakes in a DC_ERROR message and a comment.
Fix these.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c | 2 +-
drivers/gpu/drm/amd/display/dmub/inc/dmub_srv.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c b/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c
index 61cefe0a3790..b65b66025267 100644
--- a/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c
+++ b/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c
@@ -92,7 +92,7 @@ void dc_dmub_srv_cmd_execute(struct dc_dmub_srv *dc_dmub_srv)
status = dmub_srv_cmd_execute(dmub);
if (status != DMUB_STATUS_OK)
- DC_ERROR("Error starting DMUB exeuction: status=%d\n", status);
+ DC_ERROR("Error starting DMUB execution: status=%d\n", status);
}
void dc_dmub_srv_wait_idle(struct dc_dmub_srv *dc_dmub_srv)
diff --git a/drivers/gpu/drm/amd/display/dmub/inc/dmub_srv.h b/drivers/gpu/drm/amd/display/dmub/inc/dmub_srv.h
index aa8f0396616d..45e427d1952e 100644
--- a/drivers/gpu/drm/amd/display/dmub/inc/dmub_srv.h
+++ b/drivers/gpu/drm/amd/display/dmub/inc/dmub_srv.h
@@ -416,7 +416,7 @@ enum dmub_status dmub_srv_cmd_queue(struct dmub_srv *dmub,
* dmub_srv_cmd_execute() - Executes a queued sequence to the dmub
* @dmub: the dmub service
*
- * Begins exeuction of queued commands on the dmub.
+ * Begins execution of queued commands on the dmub.
*
* Return:
* DMUB_STATUS_OK - success
--
2.20.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH][next] drm/amd/display: fix spelling mistake "exeuction" -> "execution"
2019-11-09 19:49 [PATCH][next] drm/amd/display: fix spelling mistake "exeuction" -> "execution" Colin King
@ 2019-11-11 13:37 ` Kazlauskas, Nicholas
[not found] ` <633bbabf-56d4-ad4a-9d4e-9562e7122d17-5C7GfCeVMHo@public.gmane.org>
2020-06-04 10:35 ` [PATCH][next] drm/amd/display: fix spelling mistake: "propogation" -> "propagation" Colin King
` (2 subsequent siblings)
3 siblings, 1 reply; 10+ messages in thread
From: Kazlauskas, Nicholas @ 2019-11-11 13:37 UTC (permalink / raw)
To: Colin King, Harry Wentland, Leo Li, Alex Deucher,
Christian König, David Zhou, David Airlie, Daniel Vetter,
amd-gfx, dri-devel
Cc: kernel-janitors, linux-kernel
On 2019-11-09 2:49 p.m., Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> There are spelling mistakes in a DC_ERROR message and a comment.
> Fix these.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Thanks!
Nicholas Kazlauskas
> ---
> drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c | 2 +-
> drivers/gpu/drm/amd/display/dmub/inc/dmub_srv.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c b/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c
> index 61cefe0a3790..b65b66025267 100644
> --- a/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c
> +++ b/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c
> @@ -92,7 +92,7 @@ void dc_dmub_srv_cmd_execute(struct dc_dmub_srv *dc_dmub_srv)
>
> status = dmub_srv_cmd_execute(dmub);
> if (status != DMUB_STATUS_OK)
> - DC_ERROR("Error starting DMUB exeuction: status=%d\n", status);
> + DC_ERROR("Error starting DMUB execution: status=%d\n", status);
> }
>
> void dc_dmub_srv_wait_idle(struct dc_dmub_srv *dc_dmub_srv)
> diff --git a/drivers/gpu/drm/amd/display/dmub/inc/dmub_srv.h b/drivers/gpu/drm/amd/display/dmub/inc/dmub_srv.h
> index aa8f0396616d..45e427d1952e 100644
> --- a/drivers/gpu/drm/amd/display/dmub/inc/dmub_srv.h
> +++ b/drivers/gpu/drm/amd/display/dmub/inc/dmub_srv.h
> @@ -416,7 +416,7 @@ enum dmub_status dmub_srv_cmd_queue(struct dmub_srv *dmub,
> * dmub_srv_cmd_execute() - Executes a queued sequence to the dmub
> * @dmub: the dmub service
> *
> - * Begins exeuction of queued commands on the dmub.
> + * Begins execution of queued commands on the dmub.
> *
> * Return:
> * DMUB_STATUS_OK - success
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH][next] drm/amd/display: fix spelling mistake "exeuction" -> "execution"
[not found] ` <633bbabf-56d4-ad4a-9d4e-9562e7122d17-5C7GfCeVMHo@public.gmane.org>
@ 2019-11-11 17:28 ` Alex Deucher
0 siblings, 0 replies; 10+ messages in thread
From: Alex Deucher @ 2019-11-11 17:28 UTC (permalink / raw)
To: Kazlauskas, Nicholas
Cc: David Zhou, Leo Li, kernel-janitors-u79uwXL29TY76Z2rM5mHXA, LKML,
amd-gfx list, David Airlie, Maling list - DRI developers,
Daniel Vetter, Alex Deucher, Colin King, Harry Wentland,
Christian König
Applied. Thanks!
Alex
On Mon, Nov 11, 2019 at 8:37 AM Kazlauskas, Nicholas
<nicholas.kazlauskas@amd.com> wrote:
>
> On 2019-11-09 2:49 p.m., Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > There are spelling mistakes in a DC_ERROR message and a comment.
> > Fix these.
> >
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
>
> Thanks!
>
> Nicholas Kazlauskas
>
> > ---
> > drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c | 2 +-
> > drivers/gpu/drm/amd/display/dmub/inc/dmub_srv.h | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c b/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c
> > index 61cefe0a3790..b65b66025267 100644
> > --- a/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c
> > +++ b/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c
> > @@ -92,7 +92,7 @@ void dc_dmub_srv_cmd_execute(struct dc_dmub_srv *dc_dmub_srv)
> >
> > status = dmub_srv_cmd_execute(dmub);
> > if (status != DMUB_STATUS_OK)
> > - DC_ERROR("Error starting DMUB exeuction: status=%d\n", status);
> > + DC_ERROR("Error starting DMUB execution: status=%d\n", status);
> > }
> >
> > void dc_dmub_srv_wait_idle(struct dc_dmub_srv *dc_dmub_srv)
> > diff --git a/drivers/gpu/drm/amd/display/dmub/inc/dmub_srv.h b/drivers/gpu/drm/amd/display/dmub/inc/dmub_srv.h
> > index aa8f0396616d..45e427d1952e 100644
> > --- a/drivers/gpu/drm/amd/display/dmub/inc/dmub_srv.h
> > +++ b/drivers/gpu/drm/amd/display/dmub/inc/dmub_srv.h
> > @@ -416,7 +416,7 @@ enum dmub_status dmub_srv_cmd_queue(struct dmub_srv *dmub,
> > * dmub_srv_cmd_execute() - Executes a queued sequence to the dmub
> > * @dmub: the dmub service
> > *
> > - * Begins exeuction of queued commands on the dmub.
> > + * Begins execution of queued commands on the dmub.
> > *
> > * Return:
> > * DMUB_STATUS_OK - success
> >
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH][next] drm/amd/display: fix spelling mistake: "propogation" -> "propagation"
2019-11-09 19:49 [PATCH][next] drm/amd/display: fix spelling mistake "exeuction" -> "execution" Colin King
2019-11-11 13:37 ` Kazlauskas, Nicholas
@ 2020-06-04 10:35 ` Colin King
2020-06-04 18:55 ` Alex Deucher
2020-08-04 17:34 ` [PATCH][next] drm/amd/display: fix spelling mistake "Usupported" -> "Unsupported" Colin King
2021-01-20 9:26 ` [PATCH][next] drm/amd/display: Fix spelling mistake of function name Colin King
3 siblings, 1 reply; 10+ messages in thread
From: Colin King @ 2020-06-04 10:35 UTC (permalink / raw)
To: Harry Wentland, Leo Li, Alex Deucher, Christian König,
David Airlie, Daniel Vetter, Bhawanpreet Lakha, amd-gfx,
dri-devel
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
There is a spelling mistake in a dml_print message. Fix it.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c b/drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c
index 65da6304d6a6..2a32ed6682fc 100644
--- a/drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c
+++ b/drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c
@@ -1308,7 +1308,7 @@ static bool CalculatePrefetchSchedule(
dml_print("DML: Tr0: %fus - time to fetch first row of data pagetables and first row of meta data (done in parallel)\n", TimeForFetchingRowInVBlank);
dml_print("DML: Tr1: %fus - time to fetch second row of data pagetables and second row of meta data (done in parallel)\n", TimeForFetchingRowInVBlank);
dml_print("DML: Tsw: %fus = time to fetch enough pixel data and cursor data to feed the scalers init position and detile\n", (double)LinesToRequestPrefetchPixelData * LineTime);
- dml_print("DML: To: %fus - time for propogation from scaler to optc\n", (*DSTYAfterScaler + ((*DSTXAfterScaler) / (double) myPipe->HTotal)) * LineTime);
+ dml_print("DML: To: %fus - time for propagation from scaler to optc\n", (*DSTYAfterScaler + ((*DSTXAfterScaler) / (double) myPipe->HTotal)) * LineTime);
dml_print("DML: Tvstartup - Tsetup - Tcalc - Twait - Tpre - To > 0\n");
dml_print("DML: Tslack(pre): %fus - time left over in schedule\n", VStartup * LineTime - TimeForFetchingMetaPTE - 2 * TimeForFetchingRowInVBlank - (*DSTYAfterScaler + ((*DSTXAfterScaler) / (double) myPipe->HTotal)) * LineTime - TWait - TCalc - Tsetup);
dml_print("DML: row_bytes = dpte_row_bytes (per_pipe) = PixelPTEBytesPerRow = : %d\n", PixelPTEBytesPerRow);
--
2.25.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH][next] drm/amd/display: fix spelling mistake: "propogation" -> "propagation"
2020-06-04 10:35 ` [PATCH][next] drm/amd/display: fix spelling mistake: "propogation" -> "propagation" Colin King
@ 2020-06-04 18:55 ` Alex Deucher
0 siblings, 0 replies; 10+ messages in thread
From: Alex Deucher @ 2020-06-04 18:55 UTC (permalink / raw)
To: Colin King
Cc: Leo Li, Bhawanpreet Lakha, kernel-janitors, LKML, amd-gfx list,
David Airlie, Maling list - DRI developers, Daniel Vetter,
Alex Deucher, Harry Wentland, Christian König
Applied. thanks!
Alex
On Thu, Jun 4, 2020 at 6:35 AM Colin King <colin.king@canonical.com> wrote:
>
> From: Colin Ian King <colin.king@canonical.com>
>
> There is a spelling mistake in a dml_print message. Fix it.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c b/drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c
> index 65da6304d6a6..2a32ed6682fc 100644
> --- a/drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c
> +++ b/drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c
> @@ -1308,7 +1308,7 @@ static bool CalculatePrefetchSchedule(
> dml_print("DML: Tr0: %fus - time to fetch first row of data pagetables and first row of meta data (done in parallel)\n", TimeForFetchingRowInVBlank);
> dml_print("DML: Tr1: %fus - time to fetch second row of data pagetables and second row of meta data (done in parallel)\n", TimeForFetchingRowInVBlank);
> dml_print("DML: Tsw: %fus = time to fetch enough pixel data and cursor data to feed the scalers init position and detile\n", (double)LinesToRequestPrefetchPixelData * LineTime);
> - dml_print("DML: To: %fus - time for propogation from scaler to optc\n", (*DSTYAfterScaler + ((*DSTXAfterScaler) / (double) myPipe->HTotal)) * LineTime);
> + dml_print("DML: To: %fus - time for propagation from scaler to optc\n", (*DSTYAfterScaler + ((*DSTXAfterScaler) / (double) myPipe->HTotal)) * LineTime);
> dml_print("DML: Tvstartup - Tsetup - Tcalc - Twait - Tpre - To > 0\n");
> dml_print("DML: Tslack(pre): %fus - time left over in schedule\n", VStartup * LineTime - TimeForFetchingMetaPTE - 2 * TimeForFetchingRowInVBlank - (*DSTYAfterScaler + ((*DSTXAfterScaler) / (double) myPipe->HTotal)) * LineTime - TWait - TCalc - Tsetup);
> dml_print("DML: row_bytes = dpte_row_bytes (per_pipe) = PixelPTEBytesPerRow = : %d\n", PixelPTEBytesPerRow);
> --
> 2.25.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH][next] drm/amd/display: fix spelling mistake "Usupported" -> "Unsupported"
2019-11-09 19:49 [PATCH][next] drm/amd/display: fix spelling mistake "exeuction" -> "execution" Colin King
2019-11-11 13:37 ` Kazlauskas, Nicholas
2020-06-04 10:35 ` [PATCH][next] drm/amd/display: fix spelling mistake: "propogation" -> "propagation" Colin King
@ 2020-08-04 17:34 ` Colin King
2020-08-04 17:39 ` NAK: " Colin Ian King
2021-01-20 9:26 ` [PATCH][next] drm/amd/display: Fix spelling mistake of function name Colin King
3 siblings, 1 reply; 10+ messages in thread
From: Colin King @ 2020-08-04 17:34 UTC (permalink / raw)
To: Alex Deucher, Christian König, David Zhou, David Airlie,
amd-gfx, dri-devel
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
There are spelling mistakes in two DRM_ERROR error messages. Fix them.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index 27579443cdc5..fe5f6350e288 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -1549,7 +1549,7 @@ static int amdgpu_dm_initialize_drm_device(struct amdgpu_device *adev)
break;
#endif
default:
- DRM_ERROR("Usupported ASIC type: 0x%X\n", adev->asic_type);
+ DRM_ERROR("Unsupported ASIC type: 0x%X\n", adev->asic_type);
goto fail;
}
@@ -1743,7 +1743,7 @@ static int dm_early_init(void *handle)
break;
#endif
default:
- DRM_ERROR("Usupported ASIC type: 0x%X\n", adev->asic_type);
+ DRM_ERROR("Unsupported ASIC type: 0x%X\n", adev->asic_type);
return -EINVAL;
}
--
2.27.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* NAK: [PATCH][next] drm/amd/display: fix spelling mistake "Usupported" -> "Unsupported"
2020-08-04 17:34 ` [PATCH][next] drm/amd/display: fix spelling mistake "Usupported" -> "Unsupported" Colin King
@ 2020-08-04 17:39 ` Colin Ian King
0 siblings, 0 replies; 10+ messages in thread
From: Colin Ian King @ 2020-08-04 17:39 UTC (permalink / raw)
To: Alex Deucher, Christian König, David Zhou, David Airlie,
amd-gfx, dri-devel
Cc: kernel-janitors, linux-kernel
On 04/08/2020 18:34, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> There are spelling mistakes in two DRM_ERROR error messages. Fix them.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index 27579443cdc5..fe5f6350e288 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -1549,7 +1549,7 @@ static int amdgpu_dm_initialize_drm_device(struct amdgpu_device *adev)
> break;
> #endif
> default:
> - DRM_ERROR("Usupported ASIC type: 0x%X\n", adev->asic_type);
> + DRM_ERROR("Unsupported ASIC type: 0x%X\n", adev->asic_type);
> goto fail;
> }
>
> @@ -1743,7 +1743,7 @@ static int dm_early_init(void *handle)
> break;
> #endif
> default:
> - DRM_ERROR("Usupported ASIC type: 0x%X\n", adev->asic_type);
> + DRM_ERROR("Unsupported ASIC type: 0x%X\n", adev->asic_type);
> return -EINVAL;
> }
>
>
Nack. I was on the wrong repo.
Colin
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH][next] drm/amd/display: Fix spelling mistake of function name
2019-11-09 19:49 [PATCH][next] drm/amd/display: fix spelling mistake "exeuction" -> "execution" Colin King
` (2 preceding siblings ...)
2020-08-04 17:34 ` [PATCH][next] drm/amd/display: fix spelling mistake "Usupported" -> "Unsupported" Colin King
@ 2021-01-20 9:26 ` Colin King
2021-01-20 14:46 ` Harry Wentland
3 siblings, 1 reply; 10+ messages in thread
From: Colin King @ 2021-01-20 9:26 UTC (permalink / raw)
To: Harry Wentland, Leo Li, Alex Deucher, Christian König,
David Airlie, Daniel Vetter, Rodrigo Siqueira, amd-gfx,
dri-devel
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
There are two spelling mistakes of the function name, fix this
by using __func__ instead of a hard coded name string.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/gpu/drm/amd/display/dc/core/dc_link.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
index c16af3983fdb..91d4130cd2cb 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
@@ -1602,7 +1602,7 @@ static bool dc_link_construct(struct dc_link *link,
link->psr_settings.psr_version = DC_PSR_VERSION_UNSUPPORTED;
- DC_LOG_DC("BIOS object table - dc_link_contruct finished successfully.\n");
+ DC_LOG_DC("BIOS object table - %s finished successfully.\n", __func__);
return true;
device_tag_fail:
link->link_enc->funcs->destroy(&link->link_enc);
@@ -1619,7 +1619,7 @@ static bool dc_link_construct(struct dc_link *link,
link->hpd_gpio = NULL;
}
- DC_LOG_DC("BIOS object table - dc_link_contruct failed.\n");
+ DC_LOG_DC("BIOS object table - %s failed.\n", __func__);
kfree(info);
return false;
--
2.29.2
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH][next] drm/amd/display: Fix spelling mistake of function name
2021-01-20 9:26 ` [PATCH][next] drm/amd/display: Fix spelling mistake of function name Colin King
@ 2021-01-20 14:46 ` Harry Wentland
2021-01-20 21:58 ` Alex Deucher
0 siblings, 1 reply; 10+ messages in thread
From: Harry Wentland @ 2021-01-20 14:46 UTC (permalink / raw)
To: Colin King, Leo Li, Alex Deucher, Christian König,
David Airlie, Daniel Vetter, Rodrigo Siqueira, amd-gfx,
dri-devel
Cc: kernel-janitors, linux-kernel
On 2021-01-20 4:26 a.m., Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Harry
> There are two spelling mistakes of the function name, fix this
> by using __func__ instead of a hard coded name string.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/gpu/drm/amd/display/dc/core/dc_link.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> index c16af3983fdb..91d4130cd2cb 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> @@ -1602,7 +1602,7 @@ static bool dc_link_construct(struct dc_link *link,
>
> link->psr_settings.psr_version = DC_PSR_VERSION_UNSUPPORTED;
>
> - DC_LOG_DC("BIOS object table - dc_link_contruct finished successfully.\n");
> + DC_LOG_DC("BIOS object table - %s finished successfully.\n", __func__);
> return true;
> device_tag_fail:
> link->link_enc->funcs->destroy(&link->link_enc);
> @@ -1619,7 +1619,7 @@ static bool dc_link_construct(struct dc_link *link,
> link->hpd_gpio = NULL;
> }
>
> - DC_LOG_DC("BIOS object table - dc_link_contruct failed.\n");
> + DC_LOG_DC("BIOS object table - %s failed.\n", __func__);
> kfree(info);
>
> return false;
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH][next] drm/amd/display: Fix spelling mistake of function name
2021-01-20 14:46 ` Harry Wentland
@ 2021-01-20 21:58 ` Alex Deucher
0 siblings, 0 replies; 10+ messages in thread
From: Alex Deucher @ 2021-01-20 21:58 UTC (permalink / raw)
To: Harry Wentland
Cc: Leo Li, kernel-janitors, Rodrigo Siqueira, LKML, amd-gfx list,
David Airlie, Maling list - DRI developers, Daniel Vetter,
Alex Deucher, Colin King, Christian König
Applied. Thanks!
Alex
On Wed, Jan 20, 2021 at 9:46 AM Harry Wentland <harry.wentland@amd.com> wrote:
>
> On 2021-01-20 4:26 a.m., Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
>
> Reviewed-by: Harry Wentland <harry.wentland@amd.com>
>
> Harry
>
> > There are two spelling mistakes of the function name, fix this
> > by using __func__ instead of a hard coded name string.
> >
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> > ---
> > drivers/gpu/drm/amd/display/dc/core/dc_link.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> > index c16af3983fdb..91d4130cd2cb 100644
> > --- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> > +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> > @@ -1602,7 +1602,7 @@ static bool dc_link_construct(struct dc_link *link,
> >
> > link->psr_settings.psr_version = DC_PSR_VERSION_UNSUPPORTED;
> >
> > - DC_LOG_DC("BIOS object table - dc_link_contruct finished successfully.\n");
> > + DC_LOG_DC("BIOS object table - %s finished successfully.\n", __func__);
> > return true;
> > device_tag_fail:
> > link->link_enc->funcs->destroy(&link->link_enc);
> > @@ -1619,7 +1619,7 @@ static bool dc_link_construct(struct dc_link *link,
> > link->hpd_gpio = NULL;
> > }
> >
> > - DC_LOG_DC("BIOS object table - dc_link_contruct failed.\n");
> > + DC_LOG_DC("BIOS object table - %s failed.\n", __func__);
> > kfree(info);
> >
> > return false;
> >
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2021-01-20 21:58 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-09 19:49 [PATCH][next] drm/amd/display: fix spelling mistake "exeuction" -> "execution" Colin King
2019-11-11 13:37 ` Kazlauskas, Nicholas
[not found] ` <633bbabf-56d4-ad4a-9d4e-9562e7122d17-5C7GfCeVMHo@public.gmane.org>
2019-11-11 17:28 ` Alex Deucher
2020-06-04 10:35 ` [PATCH][next] drm/amd/display: fix spelling mistake: "propogation" -> "propagation" Colin King
2020-06-04 18:55 ` Alex Deucher
2020-08-04 17:34 ` [PATCH][next] drm/amd/display: fix spelling mistake "Usupported" -> "Unsupported" Colin King
2020-08-04 17:39 ` NAK: " Colin Ian King
2021-01-20 9:26 ` [PATCH][next] drm/amd/display: Fix spelling mistake of function name Colin King
2021-01-20 14:46 ` Harry Wentland
2021-01-20 21:58 ` Alex Deucher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).