Re: [PATCH] qedr: fix resource leak in qedr_create_qp

Re: [PATCH] qedr: fix resource leak in qedr_create_qp

[Keita Suzuki]

Hi,

Thank you for your comment.
I will re-label the goto statements and post the patch as version 2.

Thanks,
Keita

2020年9月10日(木) 22:24 Markus Elfring <Markus.Elfring@web.de>:
>
> > Fix this by adding a new goto label that calls qedr_free_qp_resources.
>
> …
> > +++ b/drivers/infiniband/hw/qedr/verbs.c
> …
> > @@ -2165,11 +2187,13 @@ struct ib_qp *qedr_create_qp(struct ib_pd *ibpd,
> …
> >       return &qp->ibqp;
> >
> > +err2:
> > +     qedr_free_qp_resources(dev, qp, udata);
> >  err:
> >       kfree(qp);
>
> I propose to choose further alternatives for numbered labels.
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=7fe10096c1508c7f033d34d0741809f8eecc1ed4#n485
>
> Regards,
> Markus

Re: [PATCH] qedr: fix resource leak in qedr_create_qp

[Keita Suzuki]

Hi,
thank you for the comment.
I will fix the line break and re-post the patch

Thanks,
Keita

2020年9月11日(金) 4:48 Markus Elfring <Markus.Elfring@web.de>:
>
> > I will re-label the goto statements and post the patch as version 2.
>
> Thanks for such a positive feedback.
>
>
> Another suggestion:
>
> > > Fixes: 1212767e23bb ("qedr: Add wrapping generic structure for qpidr and
> > > adjust idr routines.")
>
> Please omit a line break for this tag.
>
> Regards,
> Markus