* [PATCH][next] libbpf: fix spelling mistake "conflictling" -> "conflicting"
@ 2019-06-19 16:27 Colin King
2019-06-21 5:08 ` Andrii Nakryiko
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Colin King @ 2019-06-19 16:27 UTC (permalink / raw)
To: Alexei Starovoitov, Daniel Borkmann, Martin KaFai Lau, Song Liu,
Yonghong Song, netdev, bpf
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
There are several spelling mistakes in pr_warning messages. Fix these.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
tools/lib/bpf/libbpf.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c
index 4259c9f0cfe7..68f45a96769f 100644
--- a/tools/lib/bpf/libbpf.c
+++ b/tools/lib/bpf/libbpf.c
@@ -1169,7 +1169,7 @@ static int bpf_object__init_user_btf_map(struct bpf_object *obj,
pr_debug("map '%s': found key_size = %u.\n",
map_name, sz);
if (map->def.key_size && map->def.key_size != sz) {
- pr_warning("map '%s': conflictling key size %u != %u.\n",
+ pr_warning("map '%s': conflicting key size %u != %u.\n",
map_name, map->def.key_size, sz);
return -EINVAL;
}
@@ -1197,7 +1197,7 @@ static int bpf_object__init_user_btf_map(struct bpf_object *obj,
pr_debug("map '%s': found key [%u], sz = %lld.\n",
map_name, t->type, sz);
if (map->def.key_size && map->def.key_size != sz) {
- pr_warning("map '%s': conflictling key size %u != %lld.\n",
+ pr_warning("map '%s': conflicting key size %u != %lld.\n",
map_name, map->def.key_size, sz);
return -EINVAL;
}
@@ -1212,7 +1212,7 @@ static int bpf_object__init_user_btf_map(struct bpf_object *obj,
pr_debug("map '%s': found value_size = %u.\n",
map_name, sz);
if (map->def.value_size && map->def.value_size != sz) {
- pr_warning("map '%s': conflictling value size %u != %u.\n",
+ pr_warning("map '%s': conflicting value size %u != %u.\n",
map_name, map->def.value_size, sz);
return -EINVAL;
}
@@ -1240,7 +1240,7 @@ static int bpf_object__init_user_btf_map(struct bpf_object *obj,
pr_debug("map '%s': found value [%u], sz = %lld.\n",
map_name, t->type, sz);
if (map->def.value_size && map->def.value_size != sz) {
- pr_warning("map '%s': conflictling value size %u != %lld.\n",
+ pr_warning("map '%s': conflicting value size %u != %lld.\n",
map_name, map->def.value_size, sz);
return -EINVAL;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH][next] libbpf: fix spelling mistake "conflictling" -> "conflicting"
2019-06-19 16:27 [PATCH][next] libbpf: fix spelling mistake "conflictling" -> "conflicting" Colin King
@ 2019-06-21 5:08 ` Andrii Nakryiko
2019-06-24 14:59 ` Daniel Borkmann
2020-06-23 8:42 ` [PATCH][next] libbpf: fix spelling mistake "kallasyms" -> "kallsyms" Colin King
2 siblings, 0 replies; 6+ messages in thread
From: Andrii Nakryiko @ 2019-06-21 5:08 UTC (permalink / raw)
To: Colin King
Cc: Alexei Starovoitov, Daniel Borkmann, Martin KaFai Lau, Song Liu,
Yonghong Song, Networking, bpf, kernel-janitors, open list
On Wed, Jun 19, 2019 at 9:28 AM Colin King <colin.king@canonical.com> wrote:
>
> From: Colin Ian King <colin.king@canonical.com>
>
> There are several spelling mistakes in pr_warning messages. Fix these.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
Oh, the beauty of copy/pasting same typo 4 times :)
Thanks for fixing! Can you please re-submit with [PATCH bpf-next]
subject prefix, as it's intended for bpf-next tree. With that:
Acked-by: Andrii Nakryiko <andriin@fb.com>
> tools/lib/bpf/libbpf.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
<snip>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH][next] libbpf: fix spelling mistake "conflictling" -> "conflicting"
2019-06-19 16:27 [PATCH][next] libbpf: fix spelling mistake "conflictling" -> "conflicting" Colin King
2019-06-21 5:08 ` Andrii Nakryiko
@ 2019-06-24 14:59 ` Daniel Borkmann
2020-06-23 8:42 ` [PATCH][next] libbpf: fix spelling mistake "kallasyms" -> "kallsyms" Colin King
2 siblings, 0 replies; 6+ messages in thread
From: Daniel Borkmann @ 2019-06-24 14:59 UTC (permalink / raw)
To: Colin King, Alexei Starovoitov, Martin KaFai Lau, Song Liu,
Yonghong Song, netdev, bpf
Cc: kernel-janitors, linux-kernel
On 06/19/2019 06:27 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> There are several spelling mistakes in pr_warning messages. Fix these.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied, thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH][next] libbpf: fix spelling mistake "kallasyms" -> "kallsyms"
2019-06-19 16:27 [PATCH][next] libbpf: fix spelling mistake "conflictling" -> "conflicting" Colin King
2019-06-21 5:08 ` Andrii Nakryiko
2019-06-24 14:59 ` Daniel Borkmann
@ 2020-06-23 8:42 ` Colin King
2020-06-23 18:56 ` Andrii Nakryiko
2020-06-24 14:19 ` Daniel Borkmann
2 siblings, 2 replies; 6+ messages in thread
From: Colin King @ 2020-06-23 8:42 UTC (permalink / raw)
To: Alexei Starovoitov, Daniel Borkmann, Martin KaFai Lau, Song Liu,
Yonghong Song, Andrii Nakryiko, John Fastabend, KP Singh, netdev,
bpf
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
There is a spelling mistake in a pr_warn message. Fix it.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
tools/lib/bpf/libbpf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c
index 18461deb1b19..deea27aadcef 100644
--- a/tools/lib/bpf/libbpf.c
+++ b/tools/lib/bpf/libbpf.c
@@ -5741,7 +5741,7 @@ static int bpf_object__read_kallsyms_file(struct bpf_object *obj)
if (ret = EOF && feof(f))
break;
if (ret != 3) {
- pr_warn("failed to read kallasyms entry: %d\n", ret);
+ pr_warn("failed to read kallsyms entry: %d\n", ret);
err = -EINVAL;
goto out;
}
--
2.27.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH][next] libbpf: fix spelling mistake "kallasyms" -> "kallsyms"
2020-06-23 8:42 ` [PATCH][next] libbpf: fix spelling mistake "kallasyms" -> "kallsyms" Colin King
@ 2020-06-23 18:56 ` Andrii Nakryiko
2020-06-24 14:19 ` Daniel Borkmann
1 sibling, 0 replies; 6+ messages in thread
From: Andrii Nakryiko @ 2020-06-23 18:56 UTC (permalink / raw)
To: Colin King
Cc: Alexei Starovoitov, Daniel Borkmann, Martin KaFai Lau, Song Liu,
Yonghong Song, Andrii Nakryiko, John Fastabend, KP Singh,
Networking, bpf, kernel-janitors, open list
On Tue, Jun 23, 2020 at 1:43 AM Colin King <colin.king@canonical.com> wrote:
>
> From: Colin Ian King <colin.king@canonical.com>
>
> There is a spelling mistake in a pr_warn message. Fix it.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
Acked-by: Andrii Nakryiko <andriin@fb.com>
> tools/lib/bpf/libbpf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c
> index 18461deb1b19..deea27aadcef 100644
> --- a/tools/lib/bpf/libbpf.c
> +++ b/tools/lib/bpf/libbpf.c
> @@ -5741,7 +5741,7 @@ static int bpf_object__read_kallsyms_file(struct bpf_object *obj)
> if (ret = EOF && feof(f))
> break;
> if (ret != 3) {
> - pr_warn("failed to read kallasyms entry: %d\n", ret);
> + pr_warn("failed to read kallsyms entry: %d\n", ret);
> err = -EINVAL;
> goto out;
> }
> --
> 2.27.0
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH][next] libbpf: fix spelling mistake "kallasyms" -> "kallsyms"
2020-06-23 8:42 ` [PATCH][next] libbpf: fix spelling mistake "kallasyms" -> "kallsyms" Colin King
2020-06-23 18:56 ` Andrii Nakryiko
@ 2020-06-24 14:19 ` Daniel Borkmann
1 sibling, 0 replies; 6+ messages in thread
From: Daniel Borkmann @ 2020-06-24 14:19 UTC (permalink / raw)
To: Colin King, Alexei Starovoitov, Martin KaFai Lau, Song Liu,
Yonghong Song, Andrii Nakryiko, John Fastabend, KP Singh, netdev,
bpf
Cc: kernel-janitors, linux-kernel
On 6/23/20 10:42 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> There is a spelling mistake in a pr_warn message. Fix it.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied, thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-06-24 14:19 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-19 16:27 [PATCH][next] libbpf: fix spelling mistake "conflictling" -> "conflicting" Colin King
2019-06-21 5:08 ` Andrii Nakryiko
2019-06-24 14:59 ` Daniel Borkmann
2020-06-23 8:42 ` [PATCH][next] libbpf: fix spelling mistake "kallasyms" -> "kallsyms" Colin King
2020-06-23 18:56 ` Andrii Nakryiko
2020-06-24 14:19 ` Daniel Borkmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).