* [patch 1/2] xprtrdma: clean up some curly braces
@ 2015-11-05 8:37 Dan Carpenter
2015-11-05 14:06 ` Chuck Lever
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2015-11-05 8:37 UTC (permalink / raw)
To: Trond Myklebust
Cc: Jeff Layton, Anna Schumaker, Chuck Lever, Sagi Grimberg,
Steve Wise, Doug Ledford, linux-nfs, kernel-janitors
It doesn't matter either way, but the curly braces were clearly intended
here. It causes a Smatch warning.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/net/sunrpc/xprtrdma/verbs.c b/net/sunrpc/xprtrdma/verbs.c
index eadd1655..2cc1014 100644
--- a/net/sunrpc/xprtrdma/verbs.c
+++ b/net/sunrpc/xprtrdma/verbs.c
@@ -852,10 +852,11 @@ retry:
if (extras) {
rc = rpcrdma_ep_post_extra_recv(r_xprt, extras);
- if (rc)
+ if (rc) {
pr_warn("%s: rpcrdma_ep_post_extra_recv: %i\n",
__func__, rc);
rc = 0;
+ }
}
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch 1/2] xprtrdma: clean up some curly braces
2015-11-05 8:37 [patch 1/2] xprtrdma: clean up some curly braces Dan Carpenter
@ 2015-11-05 14:06 ` Chuck Lever
0 siblings, 0 replies; 2+ messages in thread
From: Chuck Lever @ 2015-11-05 14:06 UTC (permalink / raw)
To: Dan Carpenter
Cc: Trond Myklebust, Jeff Layton, Anna Schumaker, Sagi Grimberg,
Steve Wise, Doug Ledford, Linux NFS Mailing List,
kernel-janitors
> On Nov 5, 2015, at 3:37 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> It doesn't matter either way, but the curly braces were clearly intended
> here. It causes a Smatch warning.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Chuck Lever <chuck.lever@oracle.com>
> diff --git a/net/sunrpc/xprtrdma/verbs.c b/net/sunrpc/xprtrdma/verbs.c
> index eadd1655..2cc1014 100644
> --- a/net/sunrpc/xprtrdma/verbs.c
> +++ b/net/sunrpc/xprtrdma/verbs.c
> @@ -852,10 +852,11 @@ retry:
>
> if (extras) {
> rc = rpcrdma_ep_post_extra_recv(r_xprt, extras);
> - if (rc)
> + if (rc) {
> pr_warn("%s: rpcrdma_ep_post_extra_recv: %i\n",
> __func__, rc);
> rc = 0;
> + }
> }
> }
>
—
Chuck Lever
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-11-05 14:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-05 8:37 [patch 1/2] xprtrdma: clean up some curly braces Dan Carpenter
2015-11-05 14:06 ` Chuck Lever
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).