From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: gregkh@linuxfoundation.org, jirislaby@kernel.org,
lukas@wunner.de, yangyingliang@huawei.com,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/2] serial: 8250: Use 'hlist_for_each_entry' to simplify code
Date: Wed, 28 Apr 2021 12:05:26 +0300 [thread overview]
Message-ID: <YIklVhaY0+kV57jV@smile.fi.intel.com> (raw)
In-Reply-To: <14024ddeb2b3a8c5b0138b5ba5083f54d00164a9.1619594713.git.christophe.jaillet@wanadoo.fr>
On Wed, Apr 28, 2021 at 09:30:40AM +0200, Christophe JAILLET wrote:
> Use 'hlist_for_each_entry' instead of hand writing it.
> This saves a few lines of code.
>
> The comment about warning generated by some gcc version is also removed.
> The way 'hlist_for_each_entry' is written should prevent such a warning to
> be emitted.
I checked the implementation of the macros vs. this usage and below seems legit.
However it indeed needs more test coverage because it's sensitive piece of code.
FWIW,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
(with the above caveat)
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> Compile tested only
> ---
> drivers/tty/serial/8250/8250_core.c | 18 ++++--------------
> 1 file changed, 4 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c
> index cae61d1ebec5..081b773a54c9 100644
> --- a/drivers/tty/serial/8250/8250_core.c
> +++ b/drivers/tty/serial/8250/8250_core.c
> @@ -172,7 +172,6 @@ static void serial_do_unlink(struct irq_info *i, struct uart_8250_port *up)
> static int serial_link_irq_chain(struct uart_8250_port *up)
> {
> struct hlist_head *h;
> - struct hlist_node *n;
> struct irq_info *i;
> int ret;
>
> @@ -180,13 +179,11 @@ static int serial_link_irq_chain(struct uart_8250_port *up)
>
> h = &irq_lists[up->port.irq % NR_IRQ_HASH];
>
> - hlist_for_each(n, h) {
> - i = hlist_entry(n, struct irq_info, node);
> + hlist_for_each_entry(i, h, node)
> if (i->irq == up->port.irq)
> break;
> - }
>
> - if (n == NULL) {
> + if (i == NULL) {
> i = kzalloc(sizeof(struct irq_info), GFP_KERNEL);
> if (i == NULL) {
> mutex_unlock(&hash_mutex);
> @@ -220,25 +217,18 @@ static int serial_link_irq_chain(struct uart_8250_port *up)
>
> static void serial_unlink_irq_chain(struct uart_8250_port *up)
> {
> - /*
> - * yes, some broken gcc emit "warning: 'i' may be used uninitialized"
> - * but no, we are not going to take a patch that assigns NULL below.
> - */
> struct irq_info *i;
> - struct hlist_node *n;
> struct hlist_head *h;
>
> mutex_lock(&hash_mutex);
>
> h = &irq_lists[up->port.irq % NR_IRQ_HASH];
>
> - hlist_for_each(n, h) {
> - i = hlist_entry(n, struct irq_info, node);
> + hlist_for_each_entry(i, h, node)
> if (i->irq == up->port.irq)
> break;
> - }
>
> - BUG_ON(n == NULL);
> + BUG_ON(i == NULL);
> BUG_ON(i->head == NULL);
>
> if (list_empty(i->head))
> --
> 2.30.2
>
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2021-04-28 9:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-28 7:30 [PATCH 1/2] serial: 8250: Use 'hlist_for_each_entry' to simplify code Christophe JAILLET
2021-04-28 7:30 ` [PATCH 2/2] serial: 8250: Add an empty line and remove some useless {} Christophe JAILLET
2021-04-28 9:06 ` Andy Shevchenko
2021-04-28 9:05 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YIklVhaY0+kV57jV@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).