From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: gregkh@linuxfoundation.org, jirislaby@kernel.org,
lukas@wunner.de, yangyingliang@huawei.com,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 2/2] serial: 8250: Add an empty line and remove some useless {}
Date: Wed, 28 Apr 2021 12:06:35 +0300 [thread overview]
Message-ID: <YIklm6h4xvQlw5Wf@smile.fi.intel.com> (raw)
In-Reply-To: <257ffd691b4a062ad017333c9430d69da6dbd29a.1619594713.git.christophe.jaillet@wanadoo.fr>
On Wed, Apr 28, 2021 at 09:30:52AM +0200, Christophe JAILLET wrote:
> This fixes the following checkpatch.pl warnings:
> WARNING: Missing a blank line after declarations
> WARNING: braces {} are not necessary for any arm of this statement
If it makes somebody happier...
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/tty/serial/8250/8250_core.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c
> index 081b773a54c9..1082e76c4d37 100644
> --- a/drivers/tty/serial/8250/8250_core.c
> +++ b/drivers/tty/serial/8250/8250_core.c
> @@ -321,9 +321,9 @@ static int univ8250_setup_irq(struct uart_8250_port *up)
> * hardware interrupt, we use a timer-based system. The original
> * driver used to do this with IRQ0.
> */
> - if (!port->irq) {
> + if (!port->irq)
> mod_timer(&up->timer, jiffies + uart_poll_timeout(port));
> - } else
> + else
> retval = serial_link_irq_chain(up);
>
> return retval;
> @@ -752,6 +752,7 @@ void serial8250_suspend_port(int line)
> if (!console_suspend_enabled && uart_console(port) &&
> port->type != PORT_8250) {
> unsigned char canary = 0xa5;
> +
> serial_out(up, UART_SCR, canary);
> if (serial_in(up, UART_SCR) == canary)
> up->canary = canary;
> --
> 2.30.2
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-04-28 9:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-28 7:30 [PATCH 1/2] serial: 8250: Use 'hlist_for_each_entry' to simplify code Christophe JAILLET
2021-04-28 7:30 ` [PATCH 2/2] serial: 8250: Add an empty line and remove some useless {} Christophe JAILLET
2021-04-28 9:06 ` Andy Shevchenko [this message]
2021-04-28 9:05 ` [PATCH 1/2] serial: 8250: Use 'hlist_for_each_entry' to simplify code Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YIklm6h4xvQlw5Wf@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).