* [PATCH] media: hantro: test the correct variable in probe()
@ 2021-05-20 16:02 Dan Carpenter
2021-05-20 18:43 ` Emil Velikov
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2021-05-20 16:02 UTC (permalink / raw)
To: Ezequiel Garcia, Emil Velikov
Cc: Philipp Zabel, Mauro Carvalho Chehab, Greg Kroah-Hartman,
Hans Verkuil, linux-media, linux-rockchip, linux-staging,
kernel-janitors
This should be testing "vpu->clocks[0].clk" instead of "vpu->clocks".
Fixes: eb4cacdfb998 ("media: hantro: add fallback handling for single irq/clk")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/staging/media/hantro/hantro_drv.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/media/hantro/hantro_drv.c b/drivers/staging/media/hantro/hantro_drv.c
index 85dcb0882afc..8ac476be1682 100644
--- a/drivers/staging/media/hantro/hantro_drv.c
+++ b/drivers/staging/media/hantro/hantro_drv.c
@@ -780,8 +780,8 @@ static int hantro_probe(struct platform_device *pdev)
* actual name in the DT bindings.
*/
vpu->clocks[0].clk = devm_clk_get(&pdev->dev, NULL);
- if (IS_ERR(vpu->clocks))
- return PTR_ERR(vpu->clocks);
+ if (IS_ERR(vpu->clocks[0].clk))
+ return PTR_ERR(vpu->clocks[0].clk);
}
num_bases = vpu->variant->num_regs ?: 1;
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] media: hantro: test the correct variable in probe()
2021-05-20 16:02 [PATCH] media: hantro: test the correct variable in probe() Dan Carpenter
@ 2021-05-20 18:43 ` Emil Velikov
0 siblings, 0 replies; 2+ messages in thread
From: Emil Velikov @ 2021-05-20 18:43 UTC (permalink / raw)
To: Dan Carpenter
Cc: Ezequiel Garcia, Philipp Zabel, Mauro Carvalho Chehab,
Greg Kroah-Hartman, Hans Verkuil, linux-media, linux-rockchip,
linux-staging, kernel-janitors
Hi Dan,
Thank you for the patch.
On 2021/05/20, Dan Carpenter wrote:
> This should be testing "vpu->clocks[0].clk" instead of "vpu->clocks".
>
> Fixes: eb4cacdfb998 ("media: hantro: add fallback handling for single irq/clk")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Emil Velikov <emil.velikov@collabora.com>
-Emil
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-20 18:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-20 16:02 [PATCH] media: hantro: test the correct variable in probe() Dan Carpenter
2021-05-20 18:43 ` Emil Velikov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).