* [bug report] net: ngbe: Add build support for ngbe
@ 2022-09-01 10:26 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2022-09-01 10:26 UTC (permalink / raw)
To: mengyuanlou; +Cc: kernel-janitors
Hello Mengyuan Lou,
The patch e79e40c83b9f: "net: ngbe: Add build support for ngbe" from
Aug 26, 2022, leads to the following Smatch static checker warning:
drivers/net/ethernet/wangxun/ngbe/ngbe_main.c:54 ngbe_shutdown()
error: uninitialized symbol 'wake'.
drivers/net/ethernet/wangxun/ngbe/ngbe_main.c
47 static void ngbe_shutdown(struct pci_dev *pdev)
48 {
49 bool wake;
50
51 ngbe_dev_shutdown(pdev, &wake);
^^^^^
Never initialized.
52
53 if (system_state == SYSTEM_POWER_OFF) {
--> 54 pci_wake_from_d3(pdev, wake);
^^^^
Uninitalized.
55 pci_set_power_state(pdev, PCI_D3hot);
56 }
57 }
regards,
dan carpenter
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-09-01 10:27 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-01 10:26 [bug report] net: ngbe: Add build support for ngbe Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).