* Re: [PATCH v4] coccinelle: api: add kvfree script
[not found] <75532a99-4498-c64a-de34-c9033782aa9e@web.de>
@ 2020-07-30 19:27 ` Julia Lawall
[not found] ` <96a71d0e-ae6f-9355-b02a-b1a084376f1e@web.de>
0 siblings, 1 reply; 3+ messages in thread
From: Julia Lawall @ 2020-07-30 19:27 UTC (permalink / raw)
To: Markus Elfring
Cc: Michal Marek, Gilles Muller, kernel-janitors, Nicolas Palix,
linux-kernel, Coccinelle
> > +msg = "WARNING: kmalloc is used to allocate this memory at line %s" % (k[0].line)
> > +coccilib.org.print_todo(p[0], msg)
>
> * I find the diagnostic text insufficient.
I also find the message not very informative.
All of the other comments are not useful, and some are simply incorrect.
julia
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v4] coccinelle: api: add kvfree script
[not found] ` <96a71d0e-ae6f-9355-b02a-b1a084376f1e@web.de>
@ 2020-07-31 8:45 ` Julia Lawall
[not found] ` <06eaa1fe-5047-89f7-3995-a38d80030e7f@web.de>
0 siblings, 1 reply; 3+ messages in thread
From: Julia Lawall @ 2020-07-31 8:45 UTC (permalink / raw)
To: Markus Elfring
Cc: Michal Marek, Gilles Muller, kernel-janitors, Nicolas Palix,
linux-kernel, Coccinelle
[-- Attachment #1: Type: text/plain, Size: 802 bytes --]
On Fri, 31 Jul 2020, Markus Elfring wrote:
> >>> +msg = "WARNING: kmalloc is used to allocate this memory at line %s" % (k[0].line)
> >>> +coccilib.org.print_todo(p[0], msg)
> >>
> >> * I find the diagnostic text insufficient.
> >
> > I also find the message not very informative.
>
> Is it interesting how quick such views can change?
Yes. If one looks at something in context, one and understand it better
than the extract that you provided.
julia
> https://lore.kernel.org/cocci/alpine.DEB.2.22.394.2007302214160.2548@hadrien/
> https://systeme.lip6.fr/pipermail/cocci/2020-July/008041.html
> https://lkml.org/lkml/2020/7/30/1015
>
> “…
> Actually, the message looks fine. Sorry for the noise about that.
> …”
>
>
> Can such notifications become more helpful?
>
> Regards,
> Markus
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [v4] coccinelle: api: add kvfree script
[not found] ` <06eaa1fe-5047-89f7-3995-a38d80030e7f@web.de>
@ 2020-07-31 14:38 ` Julia Lawall
0 siblings, 0 replies; 3+ messages in thread
From: Julia Lawall @ 2020-07-31 14:38 UTC (permalink / raw)
To: Markus Elfring
Cc: Michal Marek, Gilles Muller, kernel-janitors, Nicolas Palix,
linux-kernel, Coccinelle
On Fri, 31 Jul 2020, Markus Elfring wrote:
> >>>>> +msg = "WARNING: kmalloc is used to allocate this memory at line %s" % (k[0].line)
> >>>>> +coccilib.org.print_todo(p[0], msg)
> >>>>
> >>>> * I find the diagnostic text insufficient.
> >>>
> >>> I also find the message not very informative.
> >>
> >> Is it interesting how quick such views can change?
> >
> > Yes. If one looks at something in context, one and understand it better
> > than the extract that you provided.
>
> Should the provided information (and its intention) be understandable from
> the diagnostic message alone already?
It is understandable from the message and from the positions that are
indicated. That's good enough.
julia
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-31 14:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <75532a99-4498-c64a-de34-c9033782aa9e@web.de>
2020-07-30 19:27 ` [PATCH v4] coccinelle: api: add kvfree script Julia Lawall
[not found] ` <96a71d0e-ae6f-9355-b02a-b1a084376f1e@web.de>
2020-07-31 8:45 ` Julia Lawall
[not found] ` <06eaa1fe-5047-89f7-3995-a38d80030e7f@web.de>
2020-07-31 14:38 ` [v4] " Julia Lawall
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).