kernel-janitors.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH v2 1/2] drivers: provide devm_platform_request_irq()
@ 2020-05-24  7:00 Markus Elfring
  0 siblings, 0 replies; only message in thread
From: Markus Elfring @ 2020-05-24  7:00 UTC (permalink / raw)
  To: Dejin Zheng, linux-i2c, kernel-janitors
  Cc: Ard Biesheuvel, Barry Song, Baruch Siach, Fabio Estevam,
	Florian Fainelli, Greg Kroah-Hartman, Heiko Stübner,
	Kevin Hilman, Linus Walleij, Michal Simek, Paul Cercueil,
	Rafael J. Wysocki, Ray Jui, Scott Branden, Shawn Guo,
	Vladimir Zapolskiy, Wolfram Sang, linux-kernel, Coccinelle

> It will call devm_request_irq() after platform_get_irq() function
> in many drivers, sometimes, it is not right for the error handling
> of these two functions in some drivers. so provide this function
> to simplify the driver.

I recommend to improve also this change description.
How do you think about a wording variant like the following?

   The function “devm_request_irq” is called after the
   function “platform_get_irq” in many drivers.
   The exception handling is incomplete there sometimes.
   Thus add a corresponding wrapper function for the simplification
   of the drivers.


Will a companion script for the semantic patch language (Coccinelle software)
become helpful for further support of collateral evolution?

Regards,
Markus

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-05-24  7:00 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-24  7:00 [PATCH v2 1/2] drivers: provide devm_platform_request_irq() Markus Elfring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).