From: Markus Elfring <Markus.Elfring@web.de>
To: Navid Emamdoost <navid.emamdoost@gmail.com>, netdev@vger.kernel.org
Cc: Navid Emamdoost <emamd001@umn.edu>, Kangjie Lu <kjlu@umn.edu>,
Stephen McCamant <smccaman@umn.edu>, Qiushi Wu <wu000273@umn.edu>,
"David S. Miller" <davem@davemloft.net>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: macb: fix ref count leaking via pm_runtime_get_sync
Date: Sun, 14 Jun 2020 08:56:14 +0000 [thread overview]
Message-ID: <c145121b-3d69-a02a-17f5-f0eb2f166663@web.de> (raw)
> in macb_mdio_write, …
* Will a desire evolve to improve also this commit message?
* Will the tag “Fixes” become helpful?
…
> +++ b/drivers/net/ethernet/cadence/macb_main.c
…
> @@ -3840,11 +3842,14 @@ static int at91ether_open(struct net_device *dev)
>
> ret = macb_phylink_connect(lp);
> if (ret)
> - return ret;
> + goto out;
>
> netif_start_queue(dev);
>
> return 0;
> +out:
> + pm_runtime_put(&lp->pdev->dev);
> + return ret;
> }
…
Perhaps use the label “put_runtime” instead?
Regards,
Markus
reply other threads:[~2020-06-14 8:56 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c145121b-3d69-a02a-17f5-f0eb2f166663@web.de \
--to=markus.elfring@web.de \
--cc=davem@davemloft.net \
--cc=emamd001@umn.edu \
--cc=kernel-janitors@vger.kernel.org \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=navid.emamdoost@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=smccaman@umn.edu \
--cc=wu000273@umn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).