* Re: [PATCH] net: macb: fix ref count leaking via pm_runtime_get_sync
@ 2020-06-14 8:56 Markus Elfring
0 siblings, 0 replies; only message in thread
From: Markus Elfring @ 2020-06-14 8:56 UTC (permalink / raw)
To: Navid Emamdoost, netdev
Cc: Navid Emamdoost, Kangjie Lu, Stephen McCamant, Qiushi Wu,
David S. Miller, Nicolas Ferre, kernel-janitors, linux-kernel
> in macb_mdio_write, …
* Will a desire evolve to improve also this commit message?
* Will the tag “Fixes” become helpful?
…
> +++ b/drivers/net/ethernet/cadence/macb_main.c
…
> @@ -3840,11 +3842,14 @@ static int at91ether_open(struct net_device *dev)
>
> ret = macb_phylink_connect(lp);
> if (ret)
> - return ret;
> + goto out;
>
> netif_start_queue(dev);
>
> return 0;
> +out:
> + pm_runtime_put(&lp->pdev->dev);
> + return ret;
> }
…
Perhaps use the label “put_runtime” instead?
Regards,
Markus
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-06-14 8:56 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-14 8:56 [PATCH] net: macb: fix ref count leaking via pm_runtime_get_sync Markus Elfring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).