* [PATCH] habanalabs: Fix an error handling path in 'hl_pci_probe()'
@ 2021-06-12 5:39 Christophe JAILLET
2021-06-14 8:48 ` Oded Gabbay
0 siblings, 1 reply; 2+ messages in thread
From: Christophe JAILLET @ 2021-06-12 5:39 UTC (permalink / raw)
To: ogabbay, arnd, gregkh, obitton, oshpigelman, fkassabri
Cc: linux-kernel, kernel-janitors, Christophe JAILLET
If an error occurs after a 'pci_enable_pcie_error_reporting()' call, it
must be undone by a corresponding 'pci_disable_pcie_error_reporting()'
call, as already done in the remove function.
Fixes: 2e5eda4681f9 ("habanalabs: PCIe Advanced Error Reporting support")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/misc/habanalabs/common/habanalabs_drv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/misc/habanalabs/common/habanalabs_drv.c b/drivers/misc/habanalabs/common/habanalabs_drv.c
index 64d1530db985..d15b912a347b 100644
--- a/drivers/misc/habanalabs/common/habanalabs_drv.c
+++ b/drivers/misc/habanalabs/common/habanalabs_drv.c
@@ -464,6 +464,7 @@ static int hl_pci_probe(struct pci_dev *pdev,
return 0;
disable_device:
+ pci_disable_pcie_error_reporting(pdev);
pci_set_drvdata(pdev, NULL);
destroy_hdev(hdev);
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] habanalabs: Fix an error handling path in 'hl_pci_probe()'
2021-06-12 5:39 [PATCH] habanalabs: Fix an error handling path in 'hl_pci_probe()' Christophe JAILLET
@ 2021-06-14 8:48 ` Oded Gabbay
0 siblings, 0 replies; 2+ messages in thread
From: Oded Gabbay @ 2021-06-14 8:48 UTC (permalink / raw)
To: Christophe JAILLET
Cc: Oded Gabbay, Arnd Bergmann, Greg Kroah-Hartman, Ofir Bitton,
Omer Shpigelman, farah kassabri, Linux-Kernel@Vger. Kernel. Org,
kernel-janitors
On Sat, Jun 12, 2021 at 8:42 AM Christophe JAILLET
<christophe.jaillet@wanadoo.fr> wrote:
>
> If an error occurs after a 'pci_enable_pcie_error_reporting()' call, it
> must be undone by a corresponding 'pci_disable_pcie_error_reporting()'
> call, as already done in the remove function.
>
> Fixes: 2e5eda4681f9 ("habanalabs: PCIe Advanced Error Reporting support")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/misc/habanalabs/common/habanalabs_drv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/misc/habanalabs/common/habanalabs_drv.c b/drivers/misc/habanalabs/common/habanalabs_drv.c
> index 64d1530db985..d15b912a347b 100644
> --- a/drivers/misc/habanalabs/common/habanalabs_drv.c
> +++ b/drivers/misc/habanalabs/common/habanalabs_drv.c
> @@ -464,6 +464,7 @@ static int hl_pci_probe(struct pci_dev *pdev,
> return 0;
>
> disable_device:
> + pci_disable_pcie_error_reporting(pdev);
> pci_set_drvdata(pdev, NULL);
> destroy_hdev(hdev);
>
> --
> 2.30.2
>
Thanks for catching it.
This patch is:
Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
Applied to -next.
Oded
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-14 8:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-12 5:39 [PATCH] habanalabs: Fix an error handling path in 'hl_pci_probe()' Christophe JAILLET
2021-06-14 8:48 ` Oded Gabbay
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).