* [PATCH] soc: xilinx: Fix error code in zynqmp_pm_probe()
@ 2020-06-05 11:00 Dan Carpenter
2020-06-05 11:07 ` Michal Simek
0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2020-06-05 11:00 UTC (permalink / raw)
To: Michal Simek, Tejas Patel
Cc: Rajan Vaja, Greg Kroah-Hartman, kernel-janitors, linux-kernel,
Jolly Shah, linux-arm-kernel
This should be returning PTR_ERR() but it returns IS_ERR() instead.
Fixes: ffdbae28d9d1 ("drivers: soc: xilinx: Use mailbox IPI callback")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/soc/xilinx/zynqmp_power.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/xilinx/zynqmp_power.c b/drivers/soc/xilinx/zynqmp_power.c
index 31ff49fcd078b..c556623dae024 100644
--- a/drivers/soc/xilinx/zynqmp_power.c
+++ b/drivers/soc/xilinx/zynqmp_power.c
@@ -205,7 +205,7 @@ static int zynqmp_pm_probe(struct platform_device *pdev)
rx_chan = mbox_request_channel_byname(client, "rx");
if (IS_ERR(rx_chan)) {
dev_err(&pdev->dev, "Failed to request rx channel\n");
- return IS_ERR(rx_chan);
+ return PTR_ERR(rx_chan);
}
} else if (of_find_property(pdev->dev.of_node, "interrupts", NULL)) {
irq = platform_get_irq(pdev, 0);
--
2.26.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] soc: xilinx: Fix error code in zynqmp_pm_probe()
2020-06-05 11:00 [PATCH] soc: xilinx: Fix error code in zynqmp_pm_probe() Dan Carpenter
@ 2020-06-05 11:07 ` Michal Simek
2020-06-18 8:07 ` Michal Simek
0 siblings, 1 reply; 3+ messages in thread
From: Michal Simek @ 2020-06-05 11:07 UTC (permalink / raw)
To: Dan Carpenter, Michal Simek, Tejas Patel
Cc: Rajan Vaja, Greg Kroah-Hartman, kernel-janitors, linux-kernel,
Jolly Shah, linux-arm-kernel
On 05. 06. 20 13:00, Dan Carpenter wrote:
> This should be returning PTR_ERR() but it returns IS_ERR() instead.
>
> Fixes: ffdbae28d9d1 ("drivers: soc: xilinx: Use mailbox IPI callback")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/soc/xilinx/zynqmp_power.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/xilinx/zynqmp_power.c b/drivers/soc/xilinx/zynqmp_power.c
> index 31ff49fcd078b..c556623dae024 100644
> --- a/drivers/soc/xilinx/zynqmp_power.c
> +++ b/drivers/soc/xilinx/zynqmp_power.c
> @@ -205,7 +205,7 @@ static int zynqmp_pm_probe(struct platform_device *pdev)
> rx_chan = mbox_request_channel_byname(client, "rx");
> if (IS_ERR(rx_chan)) {
> dev_err(&pdev->dev, "Failed to request rx channel\n");
> - return IS_ERR(rx_chan);
> + return PTR_ERR(rx_chan);
> }
> } else if (of_find_property(pdev->dev.of_node, "interrupts", NULL)) {
> irq = platform_get_irq(pdev, 0);
>
Reviewed-by: Michal Simek <michal.simek@xilinx.com>
Thanks,
Michal
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] soc: xilinx: Fix error code in zynqmp_pm_probe()
2020-06-05 11:07 ` Michal Simek
@ 2020-06-18 8:07 ` Michal Simek
0 siblings, 0 replies; 3+ messages in thread
From: Michal Simek @ 2020-06-18 8:07 UTC (permalink / raw)
To: Michal Simek, Dan Carpenter, Tejas Patel
Cc: Rajan Vaja, Greg Kroah-Hartman, kernel-janitors, linux-kernel,
Jolly Shah, linux-arm-kernel
On 05. 06. 20 13:07, Michal Simek wrote:
> On 05. 06. 20 13:00, Dan Carpenter wrote:
>> This should be returning PTR_ERR() but it returns IS_ERR() instead.
>>
>> Fixes: ffdbae28d9d1 ("drivers: soc: xilinx: Use mailbox IPI callback")
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>> ---
>> drivers/soc/xilinx/zynqmp_power.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/soc/xilinx/zynqmp_power.c b/drivers/soc/xilinx/zynqmp_power.c
>> index 31ff49fcd078b..c556623dae024 100644
>> --- a/drivers/soc/xilinx/zynqmp_power.c
>> +++ b/drivers/soc/xilinx/zynqmp_power.c
>> @@ -205,7 +205,7 @@ static int zynqmp_pm_probe(struct platform_device *pdev)
>> rx_chan = mbox_request_channel_byname(client, "rx");
>> if (IS_ERR(rx_chan)) {
>> dev_err(&pdev->dev, "Failed to request rx channel\n");
>> - return IS_ERR(rx_chan);
>> + return PTR_ERR(rx_chan);
>> }
>> } else if (of_find_property(pdev->dev.of_node, "interrupts", NULL)) {
>> irq = platform_get_irq(pdev, 0);
>>
>
> Reviewed-by: Michal Simek <michal.simek@xilinx.com>
Applied.
M
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-06-18 8:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-05 11:00 [PATCH] soc: xilinx: Fix error code in zynqmp_pm_probe() Dan Carpenter
2020-06-05 11:07 ` Michal Simek
2020-06-18 8:07 ` Michal Simek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).