* [PATCH] scsi: make SCSI_MOD depend on BLOCK for cleaner .config files
@ 2022-09-19 6:01 Lukas Bulwahn
2022-09-22 22:04 ` Bart Van Assche
2022-09-25 16:47 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Lukas Bulwahn @ 2022-09-19 6:01 UTC (permalink / raw)
To: James E . J . Bottomley, Martin K . Petersen, linux-scsi
Cc: kernel-janitors, linux-kernel, Lukas Bulwahn
SCSI_MOD is a helper config symbol for configuring RAID_ATTRS properly,
i.e., RAID_ATTRS needs to be m when SCSI=m.
This helper config symbol SCSI_MOD still shows up even in kernel
configurations that do not select the block subsystem and where SCSI is
not even a configuration option mentioned and selectable.
Make this SCSI_MOD depend on BLOCK, so that it only shows up when it is
slightly relevant in the kernel configuration.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
drivers/scsi/Kconfig | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
index 955cb69a5418..03e71e3d5e5b 100644
--- a/drivers/scsi/Kconfig
+++ b/drivers/scsi/Kconfig
@@ -2,9 +2,10 @@
menu "SCSI device support"
config SCSI_MOD
- tristate
- default y if SCSI=n || SCSI=y
- default m if SCSI=m
+ tristate
+ default y if SCSI=n || SCSI=y
+ default m if SCSI=m
+ depends on BLOCK
config RAID_ATTRS
tristate "RAID Transport Class"
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: make SCSI_MOD depend on BLOCK for cleaner .config files
2022-09-19 6:01 [PATCH] scsi: make SCSI_MOD depend on BLOCK for cleaner .config files Lukas Bulwahn
@ 2022-09-22 22:04 ` Bart Van Assche
2022-09-25 16:47 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Bart Van Assche @ 2022-09-22 22:04 UTC (permalink / raw)
To: Lukas Bulwahn, James E . J . Bottomley, Martin K . Petersen, linux-scsi
Cc: kernel-janitors, linux-kernel
On 9/18/22 23:01, Lukas Bulwahn wrote:
> SCSI_MOD is a helper config symbol for configuring RAID_ATTRS properly,
> i.e., RAID_ATTRS needs to be m when SCSI=m.
>
> This helper config symbol SCSI_MOD still shows up even in kernel
> configurations that do not select the block subsystem and where SCSI is
> not even a configuration option mentioned and selectable.
>
> Make this SCSI_MOD depend on BLOCK, so that it only shows up when it is
> slightly relevant in the kernel configuration.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---
> drivers/scsi/Kconfig | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
> index 955cb69a5418..03e71e3d5e5b 100644
> --- a/drivers/scsi/Kconfig
> +++ b/drivers/scsi/Kconfig
> @@ -2,9 +2,10 @@
> menu "SCSI device support"
>
> config SCSI_MOD
> - tristate
> - default y if SCSI=n || SCSI=y
> - default m if SCSI=m
> + tristate
> + default y if SCSI=n || SCSI=y
> + default m if SCSI=m
> + depends on BLOCK
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: make SCSI_MOD depend on BLOCK for cleaner .config files
2022-09-19 6:01 [PATCH] scsi: make SCSI_MOD depend on BLOCK for cleaner .config files Lukas Bulwahn
2022-09-22 22:04 ` Bart Van Assche
@ 2022-09-25 16:47 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2022-09-25 16:47 UTC (permalink / raw)
To: Lukas Bulwahn
Cc: James E . J . Bottomley, Martin K . Petersen, linux-scsi,
kernel-janitors, linux-kernel
Lukas,
> SCSI_MOD is a helper config symbol for configuring RAID_ATTRS properly,
> i.e., RAID_ATTRS needs to be m when SCSI=m.
Applied to 6.1/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-25 16:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-19 6:01 [PATCH] scsi: make SCSI_MOD depend on BLOCK for cleaner .config files Lukas Bulwahn
2022-09-22 22:04 ` Bart Van Assche
2022-09-25 16:47 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).