* [PATCH] ALSA: echoaudio: re-enable IRQs on failure path
@ 2020-07-13 10:53 Dan Carpenter
2020-07-13 16:05 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2020-07-13 10:53 UTC (permalink / raw)
To: Jaroslav Kysela, Mark Hills
Cc: kernel-janitors, alsa-devel, Chuhong Yuan, Takashi Iwai
This should be spin_unlock_irq() instead of spin_lock().
Fixes: 6c3312544873 ("ALSA: echoaudio: Prevent races in calls to set_audio_format()")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
sound/pci/echoaudio/echoaudio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/pci/echoaudio/echoaudio.c b/sound/pci/echoaudio/echoaudio.c
index e81f42811f45..6aeb99aa2414 100644
--- a/sound/pci/echoaudio/echoaudio.c
+++ b/sound/pci/echoaudio/echoaudio.c
@@ -721,7 +721,7 @@ static int pcm_prepare(struct snd_pcm_substream *substream)
spin_lock_irq(&chip->lock);
if (snd_BUG_ON(!is_pipe_allocated(chip, pipe_index))) {
- spin_unlock(&chip->lock);
+ spin_unlock_irq(&chip->lock);
return -EINVAL;
}
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ALSA: echoaudio: re-enable IRQs on failure path
2020-07-13 10:53 [PATCH] ALSA: echoaudio: re-enable IRQs on failure path Dan Carpenter
@ 2020-07-13 16:05 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2020-07-13 16:05 UTC (permalink / raw)
To: Dan Carpenter
Cc: alsa-devel, kernel-janitors, Chuhong Yuan, Takashi Iwai, Mark Hills
On Mon, 13 Jul 2020 12:53:24 +0200,
Dan Carpenter wrote:
>
> This should be spin_unlock_irq() instead of spin_lock().
>
> Fixes: 6c3312544873 ("ALSA: echoaudio: Prevent races in calls to set_audio_format()")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks, applied now.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-13 16:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-13 10:53 [PATCH] ALSA: echoaudio: re-enable IRQs on failure path Dan Carpenter
2020-07-13 16:05 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).