Re: [PATCH] serial: 8250_lpss: Fix memory leak in lpss8250_probe()

Re: [PATCH] serial: 8250_lpss: Fix memory leak in lpss8250_probe()

[Markus Elfring]

…
> In the lpss8250_probe() function, I added a label named "free_irq_vectors" to release the dynamically allocated memory region pointed to by the variable pdev, and replaced the two return statements mentioned above with goto statements to this label.

* Please improve the word wrapping according to line length preferences
  for change descriptions.

* Please choose corresponding imperative wordings.


> Fixes: e88c4cfcb7b888ac374916806f86c17d8ecaeb67

Please add a commit subject for this tag.


> Signed-off-by: LuMingYin <11570291+yin-luming@user.noreply.gitee.com>

I find the author email addresses suspicious according to the Developer's Certificate of Origin.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9-rc5#n398

Would other email addresses be more appropriate for desired patch communication?

Regards,
Markus

Re:Re: [PATCH] serial: 8250_lpss: Fix memory leak in lpss8250_probe()

[lumingyindetect]

Dear Markus,<br/><br/>Thank you for your patient guidance and advice! This is my first time submitting a patch, and I haven't fully understood the meaning of "add a commit subject for this tag" yet. Could you please provide some examples or guidance on how to add it? I appreciate your help!<br/><br/>Best regards,<br/>LuMingYin
At 2024-04-26 20:28:43, "Markus Elfring" <Markus.Elfring@web.de> wrote:
>…
>> In the lpss8250_probe() function, I added a label named "free_irq_vectors" to release the dynamically allocated memory region pointed to by the variable pdev, and replaced the two return statements mentioned above with goto statements to this label.
>
>* Please improve the word wrapping according to line length preferences
>  for change descriptions.
>
>* Please choose corresponding imperative wordings.
>
>
>> Fixes: e88c4cfcb7b888ac374916806f86c17d8ecaeb67
>
>Please add a commit subject for this tag.
>
>
>> Signed-off-by: LuMingYin <11570291+yin-luming@user.noreply.gitee.com>
>
>I find the author email addresses suspicious according to the Developer's Certificate of Origin.
>https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9-rc5#n398
>
>Would other email addresses be more appropriate for desired patch communication?
>
>Regards,
>Markus

Re: serial: 8250_lpss: Fix memory leak in lpss8250_probe()

[Markus Elfring]

> This is my first time submitting a patch, and I haven't fully understood the meaning of "add a commit subject for this tag" yet.

Would you like to take available information from published information sources
better into account?

Please take another look also at advices from the section “Describe your changes”.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9-rc5#n145


By the way:
Did you try the development tool “scripts/checkpatch.pl” out for your change approach?

Regards,
Markus

Re: [PATCH] serial: 8250_lpss: Fix memory leak in lpss8250_probe()

[Christian Heusel]

[-- Attachment #1: Type: text/plain, Size: 1038 bytes --]

On 24/04/26 09:01PM, lumingyindetect wrote:
> Dear Markus,
>
> Thank you for your patient guidance and advice! This is my first time submitting a patch, and I haven't fully understood the meaning of "add a commit subject for this tag" yet. Could you please provide some examples or guidance on how to add it? I appreciate your help!
>
> Best regards,
> LuMingYin

Hey LuMingYin,

just for your information that while he means well the advice from
Markus is not always shared by other maintainers and their inablility to
adapt to such feedback got them banned for a while on lkml. See i.e.
https://lore.kernel.org/all/2024042547-shimmy-guileless-c7f2@gregkh/
for an instance where greg is sending a relevant reply to one of their
requested changes / feedback to patches.

So just evaluate for yourself whether the feedback makes sense and just
go along of the official documentation[0] and feedback you get from the
relevant subsystem maintainers.

Cheers,
chris

[0]: https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]