* [PATCH] scsi: pcmcia: fdomain: Fix an error code in probe()
@ 2021-08-10 8:47 Dan Carpenter
2021-08-16 17:25 ` Martin K. Petersen
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2021-08-10 8:47 UTC (permalink / raw)
To: James E.J. Bottomley, Ondrej Zary
Cc: Martin K. Petersen, linux-scsi, kernel-janitors
If request_region() fails, the driver should return -EBUSY but this
code accidentally returns success.
Fixes: 8674a8aa2c39 ("scsi: fdomain: Add PCMCIA support")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/scsi/pcmcia/fdomain_cs.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/pcmcia/fdomain_cs.c b/drivers/scsi/pcmcia/fdomain_cs.c
index e42acf314d06..33df6a9ba9b5 100644
--- a/drivers/scsi/pcmcia/fdomain_cs.c
+++ b/drivers/scsi/pcmcia/fdomain_cs.c
@@ -45,8 +45,10 @@ static int fdomain_probe(struct pcmcia_device *link)
goto fail_disable;
if (!request_region(link->resource[0]->start, FDOMAIN_REGION_SIZE,
- "fdomain_cs"))
+ "fdomain_cs")) {
+ ret = -EBUSY;
goto fail_disable;
+ }
sh = fdomain_create(link->resource[0]->start, link->irq, 7, &link->dev);
if (!sh) {
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] scsi: pcmcia: fdomain: Fix an error code in probe()
2021-08-10 8:47 [PATCH] scsi: pcmcia: fdomain: Fix an error code in probe() Dan Carpenter
@ 2021-08-16 17:25 ` Martin K. Petersen
0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2021-08-16 17:25 UTC (permalink / raw)
To: Dan Carpenter
Cc: James E.J. Bottomley, Ondrej Zary, Martin K. Petersen,
linux-scsi, kernel-janitors
Hi Dan!
> If request_region() fails, the driver should return -EBUSY but this
> code accidentally returns success.
Identical fix was merged as 632c4ae6da1d.
Thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-08-16 17:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-10 8:47 [PATCH] scsi: pcmcia: fdomain: Fix an error code in probe() Dan Carpenter
2021-08-16 17:25 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).