* [PATCH -next v2] scsi: qla2xxx: Use list_move_tail instead of list_del/list_add_tail in qla_target.c
@ 2021-06-09 7:23 Baokun Li
2021-06-10 14:32 ` Himanshu Madhani
2021-06-16 2:39 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Baokun Li @ 2021-06-09 7:23 UTC (permalink / raw)
To: linux-kernel, Nilesh Javali, GR-QLogic-Storage-Upstream,
James E.J. Bottomley, Martin K. Petersen
Cc: weiyongjun1, yuehaibing, yangjihong1, yukuai3, libaokun1,
linux-scsi, kernel-janitors, Hulk Robot
Using list_move_tail() instead of list_del() + list_add_tail() in qla_target.c.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Baokun Li <libaokun1@huawei.com>
---
V1->V2:
CC mailist
drivers/scsi/qla2xxx/qla_target.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c
index 12a6848ade43..eb47140a899f 100644
--- a/drivers/scsi/qla2xxx/qla_target.c
+++ b/drivers/scsi/qla2xxx/qla_target.c
@@ -5481,8 +5481,7 @@ qlt_free_qfull_cmds(struct qla_qpair *qpair)
"%s: Unexpected cmd in QFull list %p\n", __func__,
cmd);
- list_del(&cmd->cmd_list);
- list_add_tail(&cmd->cmd_list, &free_list);
+ list_move_tail(&cmd->cmd_list, &free_list);
/* piggy back on hardware_lock for protection */
vha->hw->tgt.num_qfull_cmds_alloc--;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next v2] scsi: qla2xxx: Use list_move_tail instead of list_del/list_add_tail in qla_target.c
2021-06-09 7:23 [PATCH -next v2] scsi: qla2xxx: Use list_move_tail instead of list_del/list_add_tail in qla_target.c Baokun Li
@ 2021-06-10 14:32 ` Himanshu Madhani
2021-06-16 2:39 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Himanshu Madhani @ 2021-06-10 14:32 UTC (permalink / raw)
To: Baokun Li, linux-kernel, Nilesh Javali,
GR-QLogic-Storage-Upstream, James E.J. Bottomley,
Martin K. Petersen
Cc: weiyongjun1, yuehaibing, yangjihong1, yukuai3, linux-scsi,
kernel-janitors, Hulk Robot
On 6/9/21 2:23 AM, Baokun Li wrote:
> Using list_move_tail() instead of list_del() + list_add_tail() in qla_target.c.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Baokun Li <libaokun1@huawei.com>
> ---
> V1->V2:
> CC mailist
>
> drivers/scsi/qla2xxx/qla_target.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c
> index 12a6848ade43..eb47140a899f 100644
> --- a/drivers/scsi/qla2xxx/qla_target.c
> +++ b/drivers/scsi/qla2xxx/qla_target.c
> @@ -5481,8 +5481,7 @@ qlt_free_qfull_cmds(struct qla_qpair *qpair)
> "%s: Unexpected cmd in QFull list %p\n", __func__,
> cmd);
>
> - list_del(&cmd->cmd_list);
> - list_add_tail(&cmd->cmd_list, &free_list);
> + list_move_tail(&cmd->cmd_list, &free_list);
>
> /* piggy back on hardware_lock for protection */
> vha->hw->tgt.num_qfull_cmds_alloc--;
>
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
--
Himanshu Madhani Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next v2] scsi: qla2xxx: Use list_move_tail instead of list_del/list_add_tail in qla_target.c
2021-06-09 7:23 [PATCH -next v2] scsi: qla2xxx: Use list_move_tail instead of list_del/list_add_tail in qla_target.c Baokun Li
2021-06-10 14:32 ` Himanshu Madhani
@ 2021-06-16 2:39 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2021-06-16 2:39 UTC (permalink / raw)
To: Baokun Li
Cc: linux-kernel, Nilesh Javali, GR-QLogic-Storage-Upstream,
James E.J. Bottomley, Martin K. Petersen, weiyongjun1,
yuehaibing, yangjihong1, yukuai3, linux-scsi, kernel-janitors,
Hulk Robot
Baokun,
> Using list_move_tail() instead of list_del() + list_add_tail() in
> qla_target.c.
Applied to 5.14/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-16 2:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-09 7:23 [PATCH -next v2] scsi: qla2xxx: Use list_move_tail instead of list_del/list_add_tail in qla_target.c Baokun Li
2021-06-10 14:32 ` Himanshu Madhani
2021-06-16 2:39 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).