* First patch
@ 2018-08-02 21:49 Arkadiusz Lis
2018-08-03 6:36 ` valdis.kletnieks at vt.edu
0 siblings, 1 reply; 5+ messages in thread
From: Arkadiusz Lis @ 2018-08-02 21:49 UTC (permalink / raw)
To: kernelnewbies
Hi guys,
I created my first patch. Could you please take a look
and check for mistakes? It's a small clean up removing checkpatch.pl
warnings. It was generated using 'git format-patch master..<mybranch>'.
See below:
>From 231fa77d595536cdaacf364b02dd64fd45a6adc4 Mon Sep 17 00:00:00 2001
From: Arkadiusz Lis <areklis909@gmail.com>
Date: Thu, 2 Aug 2018 23:38:17 +0200
Subject: [PATCH] Staging: One Laptop Per Child: fix coding style and license
issues
Add argument names to the function pointers in struct
dcon_platform_data.
Add SPDX-License-Identifiers to the source files.
Signed-off-by: Arkadiusz Lis <areklis909@gmail.com>
---
drivers/staging/olpc_dcon/olpc_dcon.c | 1 +
drivers/staging/olpc_dcon/olpc_dcon.h | 6 +++---
drivers/staging/olpc_dcon/olpc_dcon_xo_1.c | 1 +
drivers/staging/olpc_dcon/olpc_dcon_xo_1_5.c | 1 +
4 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c b/drivers/staging/olpc_dcon/olpc_dcon.c
index 2744c9f..318adc4 100644
--- a/drivers/staging/olpc_dcon/olpc_dcon.c
+++ b/drivers/staging/olpc_dcon/olpc_dcon.c
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0
/*
* Mainly by David Woodhouse, somewhat modified by Jordan Crouse
*
diff --git a/drivers/staging/olpc_dcon/olpc_dcon.h b/drivers/staging/olpc_dcon/olpc_dcon.h
index fa89bb9..0ce1a7a 100644
--- a/drivers/staging/olpc_dcon/olpc_dcon.h
+++ b/drivers/staging/olpc_dcon/olpc_dcon.h
@@ -91,10 +91,10 @@ struct dcon_priv {
};
struct dcon_platform_data {
- int (*init)(struct dcon_priv *);
+ int (*init)(struct dcon_priv *dcon);
void (*bus_stabilize_wiggle)(void);
- void (*set_dconload)(int);
- int (*read_status)(u8 *);
+ void (*set_dconload)(int val);
+ int (*read_status)(u8 *status);
};
#include <linux/interrupt.h>
diff --git a/drivers/staging/olpc_dcon/olpc_dcon_xo_1.c b/drivers/staging/olpc_dcon/olpc_dcon_xo_1.c
index 633c58c..c72f492 100644
--- a/drivers/staging/olpc_dcon/olpc_dcon_xo_1.c
+++ b/drivers/staging/olpc_dcon/olpc_dcon_xo_1.c
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0
/*
* Mainly by David Woodhouse, somewhat modified by Jordan Crouse
*
diff --git a/drivers/staging/olpc_dcon/olpc_dcon_xo_1_5.c b/drivers/staging/olpc_dcon/olpc_dcon_xo_1_5.c
index 6458442..07b70eb 100644
--- a/drivers/staging/olpc_dcon/olpc_dcon_xo_1_5.c
+++ b/drivers/staging/olpc_dcon/olpc_dcon_xo_1_5.c
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0
/*
* Copyright (c) 2009,2010 One Laptop per Child
*
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* first patch
@ 2015-12-23 3:37 maoma king
2015-12-23 4:02 ` Mike Krinkin
2015-12-27 22:28 ` Jerry Snitselaar
0 siblings, 2 replies; 5+ messages in thread
From: maoma king @ 2015-12-23 3:37 UTC (permalink / raw)
To: kernelnewbies
Dear
I have sent my first patch (https://lkml.org/lkml/2015/11/18/239) to
linux-next tree.But I never received anything about it.So I sent it
again. You say "Doesn't apply to my tree :(".but it can be apply to
least linux-next branch .
I make n new patch and send it.I receive
review(https://www.mail-archive.com/linux-kernel at vger.kernel.org/msg1048115.html)
.
I want to know what's wrong with me?
how do I know that my patch is accepted?
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-08-03 6:36 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-02 21:49 First patch Arkadiusz Lis
2018-08-03 6:36 ` valdis.kletnieks at vt.edu
-- strict thread matches above, loose matches on Subject: below --
2015-12-23 3:37 first patch maoma king
2015-12-23 4:02 ` Mike Krinkin
2015-12-27 22:28 ` Jerry Snitselaar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).