From: Greg KH <greg@kroah.com>
To: Konstantin Andreev <andreev@swemel.ru>
Cc: "Valdis Klētnieks" <kernelnewbies@kernelnewbies.org>
Subject: Re: linux kernel coding style and checkpatch.pl script
Date: Thu, 26 Mar 2020 13:06:05 +0100 [thread overview]
Message-ID: <20200326120605.GA1289824@kroah.com> (raw)
In-Reply-To: <E1jHQrV-0002Zv-Ln@shelob.surriel.com>
On Thu, Mar 26, 2020 at 02:36:23PM +0300, Konstantin Andreev wrote:
> Valdis Klētnieks, 26 Mar 2020 07:13 MSK:
> >
> > To borrow from Pirates of the Carribean, "They're not exactly rules, they're more like... suggestions..."
> >
> > Don't split literal strings, it means that grepping the source tree for "already registered" fails. Making grep for a string work is more important than shutting up checkpatch.
>
> Sic! Grepping is important. Given that, why are kernel functions coded in a
>
> | static int __init loglevel(char *str)
> | {
>
> way, but not old decent
>
> | static int __init
> | loglevel(char *str)
> | {
>
> unix way?
Documentation/process/coding-style.rst
_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
next prev parent reply other threads:[~2020-03-26 12:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 9:36 linux kernel coding style and checkpatch.pl script Tomek The Messenger
2020-03-25 9:51 ` Greg KH
2020-03-26 4:13 ` Valdis Klētnieks
2020-03-26 11:36 ` Konstantin Andreev
[not found] ` <E1jHQrV-0002Zv-Ln@shelob.surriel.com>
2020-03-26 12:06 ` Greg KH [this message]
2020-03-26 13:01 ` Konstantin Andreev
[not found] ` <E1jHS2D-0004t2-IX@shelob.surriel.com>
2020-03-26 13:17 ` Greg KH
2020-03-26 10:57 ` Anuz Pratap Singh Tomar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200326120605.GA1289824@kroah.com \
--to=greg@kroah.com \
--cc=andreev@swemel.ru \
--cc=kernelnewbies@kernelnewbies.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).