From: Nicholas Mc Guire <der.herr@hofr.at>
To: Valentin Vidi?? <vvidic@valentin-vidic.from.hr>
Cc: kernelnewbies@kernelnewbies.org
Subject: Re: Fixes tag confusion
Date: Tue, 14 Apr 2020 11:16:57 +0200 [thread overview]
Message-ID: <20200414091656.GC21507@osadl.at> (raw)
In-Reply-To: <20200413194641.GR7912@valentin-vidic.from.hr>
On Mon, Apr 13, 2020 at 09:46:41PM +0200, Valentin Vidi?? wrote:
> On Mon, Apr 13, 2020 at 07:15:17PM +0200, Nicholas Mc Guire wrote:
> > linux-stable$ git log -L:get_fs_type:fs/filesystems.c | grep "^commit "
> > commit d8e9650dff48055057253ca30933605bd7d0733b
> > commit 79c0b2df79eb56fc71e54c75cd7fb3acf84370f9
> > commit 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2
> >
> > I see neither of the fix nor the fixed commit ?
> > This is on a Debian 10.3 with git version 2.20.1
> >
> > It does not seem to be a rename issue - so I'm a bit lost on this one
> > Is this a wrong expectation on my side - or am I using git in some wrong way here ?
>
> In this case it seems there is a function __get_fs_type earlier in the file
> that gets matched instead:
>
> static struct file_system_type *__get_fs_type(const char *name, int len)
> {
> ...
> }
>
> struct file_system_type *get_fs_type(const char *name)
> {
> ...
> }
>
> You can try for example:
>
> $ git log -L ':[*]get_fs_type:fs/filesystems.c' fs/filesystems.c | grep ^commit
> $ git log -L ':[^_]get_fs_type:fs/filesystems.c' fs/filesystems.c | grep ^commit
> $ git log -L ':\bget_fs_type:fs/filesystems.c' fs/filesystems.c | grep ^commit
> commit 26c5d78c976ca298e59a56f6101a97b618ba3539
> commit 41124db869b7e00e12052555f8987867ac01d70c
> commit 7f78e0351394052e1a6293e175825eb5c7869507
> commit d8e9650dff48055057253ca30933605bd7d0733b
> commit 79c0b2df79eb56fc71e54c75cd7fb3acf84370f9
> commit 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2
>
thanks - yes that does it for my case - I did not see
the function name as a regex - thanks for the clarification !
thx!
hofrat
_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
prev parent reply other threads:[~2020-04-14 9:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-13 17:15 Fixes tag confusion Nicholas Mc Guire
2020-04-13 19:46 ` Valentin Vidić
2020-04-14 9:16 ` Nicholas Mc Guire [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200414091656.GC21507@osadl.at \
--to=der.herr@hofr.at \
--cc=kernelnewbies@kernelnewbies.org \
--cc=vvidic@valentin-vidic.from.hr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).