* Fixes tag confusion
@ 2020-04-13 17:15 Nicholas Mc Guire
2020-04-13 19:46 ` Valentin Vidić
0 siblings, 1 reply; 3+ messages in thread
From: Nicholas Mc Guire @ 2020-04-13 17:15 UTC (permalink / raw)
To: Kernel Newbies
Hi !
Looking at some of the fixes tags in linux-stable e.g.
commit 27d231c0c63b -> :pnfs_alloc_ds_commits_list:fs/nfs/pnfs_nfs.c
Fixes: a9901899b649
inspecting the history of this function shows
linux-stable$ git log -L:pnfs_alloc_ds_commits_list:fs/nfs/pnfs_nfs.c | grep "^commit "
commit 27d231c0c63bb619997a24bab85d54d90ca71110
commit a9901899b649dc80ef75c14d6d78059cae14def7
commit 0cb1f6df8a63b51f276f94d94957d7a7ca757667
commit f54bcf2ecee982da47c2baf8bd87fd9ad9984651
or:
commit 9b8b17541f13
Fixes: e26733e0d0ec
gives me:
linux-stable$ git log -L:calculate_high_delay:mm/memcontrol.c | grep "^commit "
commit 9b8b17541f13809d06f6f873325305ddbb760e3e
commit e26733e0d0ec6798eca93daa300bc3f43616127f
commit d397a45fc741c80c32a14e2de008441e9976f50c
commit 0e4b01df865935007bd712cbc8e7299005b28894
commit f7e1cb6ec51b041335b5ad4dd7aefb37a56d79a6
commit b23afb93d317c65cef553b804f08dec8a7a0f7e1
the initial bug introducing commit and the fix commit are visible
But then there are other cases like:
commit 26c5d78c976c which fixed up get_fs_type in fs/filesystems.c
Fixes: 41124db869b7
commit 26c5d78c976c
<snip>
- WARN_ONCE(!fs, "request_module fs-%.*s succeeded, but still no fs?\n", len, name);
+ if (!fs)
+ pr_warn_once("request_module fs-%.*s succeeded, but still no fs?\n",
+ len, name);
<snip>
Fixes: 41124db869b7
<snip>
- if (!fs && (request_module("fs-%.*s", len, name) == 0))
+ if (!fs && (request_module("fs-%.*s", len, name) == 0)) {
fs = __get_fs_type(name, len);
+ WARN_ONCE(!fs, "request_module fs-%.*s succeeded, but still no fs?\n", len, name);
+ }
<snip>
which seem to be correct - but git log does not display them ?
linux-stable$ git log -L:get_fs_type:fs/filesystems.c | grep "^commit "
commit d8e9650dff48055057253ca30933605bd7d0733b
commit 79c0b2df79eb56fc71e54c75cd7fb3acf84370f9
commit 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2
I see neither of the fix nor the fixed commit ?
This is on a Debian 10.3 with git version 2.20.1
It does not seem to be a rename issue - so I'm a bit lost on this one
Is this a wrong expectation on my side - or am I using git in some wrong way here ?
thx!
hofrat
_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Fixes tag confusion
2020-04-13 17:15 Fixes tag confusion Nicholas Mc Guire
@ 2020-04-13 19:46 ` Valentin Vidić
2020-04-14 9:16 ` Nicholas Mc Guire
0 siblings, 1 reply; 3+ messages in thread
From: Valentin Vidić @ 2020-04-13 19:46 UTC (permalink / raw)
To: kernelnewbies
On Mon, Apr 13, 2020 at 07:15:17PM +0200, Nicholas Mc Guire wrote:
> linux-stable$ git log -L:get_fs_type:fs/filesystems.c | grep "^commit "
> commit d8e9650dff48055057253ca30933605bd7d0733b
> commit 79c0b2df79eb56fc71e54c75cd7fb3acf84370f9
> commit 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2
>
> I see neither of the fix nor the fixed commit ?
> This is on a Debian 10.3 with git version 2.20.1
>
> It does not seem to be a rename issue - so I'm a bit lost on this one
> Is this a wrong expectation on my side - or am I using git in some wrong way here ?
In this case it seems there is a function __get_fs_type earlier in the file
that gets matched instead:
static struct file_system_type *__get_fs_type(const char *name, int len)
{
...
}
struct file_system_type *get_fs_type(const char *name)
{
...
}
You can try for example:
$ git log -L ':[*]get_fs_type:fs/filesystems.c' fs/filesystems.c | grep ^commit
$ git log -L ':[^_]get_fs_type:fs/filesystems.c' fs/filesystems.c | grep ^commit
$ git log -L ':\bget_fs_type:fs/filesystems.c' fs/filesystems.c | grep ^commit
commit 26c5d78c976ca298e59a56f6101a97b618ba3539
commit 41124db869b7e00e12052555f8987867ac01d70c
commit 7f78e0351394052e1a6293e175825eb5c7869507
commit d8e9650dff48055057253ca30933605bd7d0733b
commit 79c0b2df79eb56fc71e54c75cd7fb3acf84370f9
commit 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2
--
Valentin
_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Fixes tag confusion
2020-04-13 19:46 ` Valentin Vidić
@ 2020-04-14 9:16 ` Nicholas Mc Guire
0 siblings, 0 replies; 3+ messages in thread
From: Nicholas Mc Guire @ 2020-04-14 9:16 UTC (permalink / raw)
To: Valentin Vidi??; +Cc: kernelnewbies
On Mon, Apr 13, 2020 at 09:46:41PM +0200, Valentin Vidi?? wrote:
> On Mon, Apr 13, 2020 at 07:15:17PM +0200, Nicholas Mc Guire wrote:
> > linux-stable$ git log -L:get_fs_type:fs/filesystems.c | grep "^commit "
> > commit d8e9650dff48055057253ca30933605bd7d0733b
> > commit 79c0b2df79eb56fc71e54c75cd7fb3acf84370f9
> > commit 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2
> >
> > I see neither of the fix nor the fixed commit ?
> > This is on a Debian 10.3 with git version 2.20.1
> >
> > It does not seem to be a rename issue - so I'm a bit lost on this one
> > Is this a wrong expectation on my side - or am I using git in some wrong way here ?
>
> In this case it seems there is a function __get_fs_type earlier in the file
> that gets matched instead:
>
> static struct file_system_type *__get_fs_type(const char *name, int len)
> {
> ...
> }
>
> struct file_system_type *get_fs_type(const char *name)
> {
> ...
> }
>
> You can try for example:
>
> $ git log -L ':[*]get_fs_type:fs/filesystems.c' fs/filesystems.c | grep ^commit
> $ git log -L ':[^_]get_fs_type:fs/filesystems.c' fs/filesystems.c | grep ^commit
> $ git log -L ':\bget_fs_type:fs/filesystems.c' fs/filesystems.c | grep ^commit
> commit 26c5d78c976ca298e59a56f6101a97b618ba3539
> commit 41124db869b7e00e12052555f8987867ac01d70c
> commit 7f78e0351394052e1a6293e175825eb5c7869507
> commit d8e9650dff48055057253ca30933605bd7d0733b
> commit 79c0b2df79eb56fc71e54c75cd7fb3acf84370f9
> commit 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2
>
thanks - yes that does it for my case - I did not see
the function name as a regex - thanks for the clarification !
thx!
hofrat
_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-14 9:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-13 17:15 Fixes tag confusion Nicholas Mc Guire
2020-04-13 19:46 ` Valentin Vidić
2020-04-14 9:16 ` Nicholas Mc Guire
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).