From: "Valdis Klētnieks" <valdis.kletnieks@vt.edu>
To: Irfan Ullah (울라 이르판) <irfan@dke.khu.ac.kr>
Cc: kernelnewbies@kernelnewbies.org
Subject: Re: Netlink socket returns NULL in vmx.c kernel file
Date: Wed, 23 Oct 2019 01:38:12 -0400 [thread overview]
Message-ID: <694299.1571809092@turing-police> (raw)
In-Reply-To: <CA+mB8OzS5zLSFT4P3Px87bPWXiRpgfeG9dHhwPhJ35K_s99xkA@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 375 bytes --]
On Wed, 23 Oct 2019 11:43:22 +0900, Irfan Ullah said:
> Can you please what's the problem?
To be brutally honest, your code is too unreadable to figure out
what the problem is.
First off, fix your code formatting to match Linux kernel indenting.
Second, there's a lot of code in your .h file that should be in a .c file.
Third, functions should be static when feasible.
[-- Attachment #1.2: Type: application/pgp-signature, Size: 832 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
next prev parent reply other threads:[~2019-10-23 5:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 2:43 Netlink socket returns NULL in vmx.c kernel file Irfan Ullah (울라 이르판)
2019-10-23 5:38 ` Valdis Klētnieks [this message]
2019-11-05 3:29 ` Irfan Ullah (울라 이르판)
2019-11-05 7:22 ` Greg KH
2019-11-05 8:59 ` Irfan Ullah (울라 이르판)
2019-11-05 10:43 ` Valdis Klētnieks
2019-11-08 4:54 ` Irfan Ullah (울라 이르판)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=694299.1571809092@turing-police \
--to=valdis.kletnieks@vt.edu \
--cc=irfan@dke.khu.ac.kr \
--cc=kernelnewbies@kernelnewbies.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).