Kernel upstream compile error at drivers/staging/media

Kernel upstream compile error at drivers/staging/media

[Lafan Mining]

[-- Attachment #1.1: Type: text/plain, Size: 585 bytes --]

Hello!

I'm learning the Linux Kernel and currently faced troubles with building the upstream. I git clone'd source code of master and tried to make deb-pkg. I faced compile error:

drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c: In function ‘input_system_configure_channel_sensor’:
drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c:1649:1: error: control reaches end of non-void function [-Werror=return-type]
1649 | }

What this error could be about and how to fix it? Maybe some wrong compilation flag is the cause?

Thank you!

[-- Attachment #1.2: Type: text/html, Size: 852 bytes --]

[-- Attachment #2: Type: text/plain, Size: 170 bytes --]

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: Kernel upstream compile error at drivers/staging/media

[Greg KH]

On Wed, Sep 08, 2021 at 09:39:15AM +0000, Lafan Mining wrote:
> Hello!
> 
> I'm learning the Linux Kernel and currently faced troubles with building the upstream. I git clone'd source code of master and tried to make deb-pkg. I faced compile error:
> 
> drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c: In function ‘input_system_configure_channel_sensor’:
> drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c:1649:1: error: control reaches end of non-void function [-Werror=return-type]
> 1649 | }
> 
> What this error could be about and how to fix it? Maybe some wrong compilation flag is the cause?

Please update your kernel version, this should already be fixed.

What version exactly are you trying to build?

And do you have this hardware?  If not, just turn the configuration
option off.

thanks,

greg k-h

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: Kernel upstream compile error at drivers/staging/media

[Lafan Mining]

On Wednesday, September 8th, 2021 at 12:50 PM, Greg KH <greg@kroah.com> wrote:

> Please update your kernel version, this should already be fixed.
>
> What version exactly are you trying to build?

I tried to build the latest source code available in master. Judging by the latest tag name it's v5.14-rc7.

When pulling for new changes with git pull there was "Already up to date" message.

Thank you!



_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: Kernel upstream compile error at drivers/staging/media

[Greg KH]

On Wed, Sep 08, 2021 at 10:02:50AM +0000, Lafan Mining wrote:
> On Wednesday, September 8th, 2021 at 12:50 PM, Greg KH <greg@kroah.com> wrote:
> 
> > Please update your kernel version, this should already be fixed.
> >
> > What version exactly are you trying to build?
> 
> I tried to build the latest source code available in master. Judging by the latest tag name it's v5.14-rc7.

That is quite old, 5.14 was released on August 29, and there have been
9718 changes added to the tree since then.

> When pulling for new changes with git pull there was "Already up to date" message.

What exactly is the tree you are pulling from?

thanks,

greg k-h

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: Kernel upstream compile error at drivers/staging/media

[Lafan Mining]

On Wednesday, September 8th, 2021 at 1:06 PM, Greg KH <greg@kroah.com> wrote:

> What exactly is the tree you are pulling from?

Here is my output of the clone repo

$ git remote show origin
* remote origin
  Fetch URL: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
  Push  URL: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
  HEAD branch: master
  Remote branch:
    master tracked
  Local branch configured for 'git pull':
    master merges with remote master
  Local ref configured for 'git push':
    master pushes to master (up to date)

which seems to be correct. The latest commit to master was dated 7th September. Here is the top fragment of the git log:

commit ac08b1c68d1b1ed3cebb218fc3ea2c07484eb07d (HEAD -> master, origin/master, origin/HEAD)
Merge: b339ec9c229a 742a4c49a82a
Author: Linus Torvalds <torvalds@linux-foundation.org>
Date:   Tue Sep 7 19:13:42 2021 -0700

Thank you!

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: Kernel upstream compile error at drivers/staging/media

[Lafan Mining]

On Wednesday, September 8th, 2021 at 12:50, Greg KH <greg@kroah.com> wrote:

> Please update your kernel version, this should already be fixed.

It's not. There have been sent several patches already to fix this issue. Here are 2 of them:

1. https://lkml.org/lkml/2021/9/5/146
2. https://lore.kernel.org/lkml/20210802143820.1150099-1-arnd@kernel.org/

And no one of them has been applied yet. Here is the log of the file input_system.c:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/log/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c

The latest commit was made on 2021-07-22 which actually break the build.

Thank you!


_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: Kernel upstream compile error at drivers/staging/media

[Lukas Bulwahn]

On Wed, Sep 8, 2021 at 6:00 PM Lafan Mining <lkfan@protonmail.com> wrote:
>
> On Wednesday, September 8th, 2021 at 12:50, Greg KH <greg@kroah.com> wrote:
>
> > Please update your kernel version, this should already be fixed.
>
> It's not. There have been sent several patches already to fix this issue. Here are 2 of them:
>
> 1. https://lkml.org/lkml/2021/9/5/146
> 2. https://lore.kernel.org/lkml/20210802143820.1150099-1-arnd@kernel.org/
>
> And no one of them has been applied yet. Here is the log of the file input_system.c:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/log/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c
>

Good own investigation so far.

The patch you point out is already applied to a maintainer's (Mauro's)
integration tree, and hence in linux-next:

commit 05344a1d2ea7bad3492c34299c37407bfcfed355
Author: Arnd Bergmann <arnd@arndb.de>
Date:   Mon Aug 2 16:38:14 2021 +0200

    media: atomisp: restore missing 'return' statement

    The input_system_configure_channel_sensor() function lost its final
    return code in a previous patch:

    drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c:
In function 'input_system_configure_channel_sensor':
    drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c:1649:1:
error: control reaches end of non-void function [-Werror=return-type]

    Restore what was there originally.

    Link: https://lore.kernel.org/linux-media/20210802143820.1150099-1-arnd@kernel.org
    Fixes: 728a5c64ae5f ("media: atomisp: remove dublicate code")
    Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
    Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>


So, it is just a matter of hours until Linus takes the pull request
from Mauro, v5.15-rc1 is out and the issue is resolved. If you ping
Greg with this patch being good for stable, he will pick it and
probably apply that for the v5.14 stable tree as well.

So be a bit patient, or change your config... Do you really need this
driver? Is it really important to you and your business? Then,
consider that it is currently under drivers/staging/ and might just
disappear from one day to another because nobody is aware of critical
users (that is why it is in staging in the first place).

I hope this helps,

Lukas

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: Kernel upstream compile error at drivers/staging/media

[Lafan Mining]

On Wednesday, September 8th, 2021 at 7:19 PM, Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:

> integration tree, and hence in linux-next

So generally to get the latest kernel version that is going to be merged into master soon is using linux-next's master? I looked at the https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c and it was indeed fixed.

Thanks.

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: Kernel upstream compile error at drivers/staging/media

[Lukas Bulwahn]

On Fri, Sep 10, 2021 at 12:31 PM Lafan Mining <lkfan@protonmail.com> wrote:
>
> On Wednesday, September 8th, 2021 at 7:19 PM, Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
>
> > integration tree, and hence in linux-next
>
> So generally to get the latest kernel version that is going to be merged into master soon is using linux-next's master?

That is roughly right; more details are here:
https://www.kernel.org/doc/html/latest/process/2.Process.html#next-trees

Most of it is still correct; some of it might be outdated.

E.g., I am not completely sure if Andrew Morton still does this
mentioned in the documentation: "The -mm tree integrates patches from
a long list of subsystem trees", or if most integration from a long
list of subsystem trees is nowadays completely done by Stephen
Rothwell in linux-next.

Also, possibly the statistics is outdated here in this statement: "In
a typical development cycle, approximately 5-10% of the patches going
into the mainline get there via -mm." One might need to check the
current numbers and update the percentage here.

Feel free to do a bit more research if you are interested and send a
patch to update the Documentation on what you learned.


Lukas

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies