From: David Howells <dhowells@redhat.com>
To: Robbie Harwood <rharwood@redhat.com>
Cc: dhowells@redhat.com, keyrings@vger.kernel.org
Subject: Re: [PATCH v1 2/2] asymmetric_keys: log on fatal failures in PE/pkcs7
Date: Fri, 17 Feb 2023 20:37:06 +0000 [thread overview]
Message-ID: <519730.1676666226@warthog.procyon.org.uk> (raw)
In-Reply-To: <20230217201435.39784-3-rharwood@redhat.com>
Robbie Harwood <rharwood@redhat.com> wrote:
> These particular errors can be encountered while trying to kexec when
> secureboot lockdown is in place. Without this change, even with a
> signed debug build, one still needs to reboot the machine to add the
> appropriate dyndbg parameters (since lockdown blocks debugfs).
>
> Accordingly, upgrade all pr_debug() before fatal error into pr_info().
I wonder if they should then be pr_warn() instead.
> Signed-off-by: Robbie Harwood <rharwood@redhat.com>
Acked-by: David Howells <dhowells@redhat.com>
prev parent reply other threads:[~2023-02-17 20:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-17 20:14 [PATCH v1 0/2] Fix kexec of pesigned images Robbie Harwood
2023-02-17 20:14 ` [PATCH v1 1/2] verify_pefile: relax wrapper length check Robbie Harwood
2023-02-17 21:11 ` Jarkko Sakkinen
2023-02-17 20:14 ` [PATCH v1 2/2] asymmetric_keys: log on fatal failures in PE/pkcs7 Robbie Harwood
2023-02-17 21:14 ` Jarkko Sakkinen
2023-02-17 20:36 ` [PATCH v1 1/2] verify_pefile: relax wrapper length check David Howells
2023-02-17 20:37 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=519730.1676666226@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=keyrings@vger.kernel.org \
--cc=rharwood@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).