From: Christian Brauner <christian.brauner@ubuntu.com>
To: Doug Anderson <dianders@chromium.org>,
Dmitry Vyukov <dvyukov@google.com>
Cc: Joel Fernandes <joelaf@google.com>,
Barret Rhoden <brho@google.com>,
ksummit <ksummit-discuss@lists.linuxfoundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jonathan Nieder <jrn@google.com>,
Tomasz Figa <tfiga@chromium.org>,
Han-Wen Nienhuys <hanwen@google.com>,
Theodore Tso <tytso@google.com>,
David Rientjes <rientjes@google.com>,
Dmitry Torokhov <dtor@chromium.org>
Subject: Re: [Ksummit-discuss] Allowing something Change-Id (or something like it) in kernel commits
Date: Mon, 16 Sep 2019 16:11:25 +0200 [thread overview]
Message-ID: <20190916141124.e7s3bjr4sp3bmtbp@wittgenstein> (raw)
In-Reply-To: <CAD=FV=UGX0L+HdGO5ZHvmMMR8ZBUDhMdYdfYSn7csc+cPg+KFw@mail.gmail.com>
On Mon, Aug 26, 2019 at 04:11:12PM -0700, Doug Anderson wrote:
> Hi,
>
> On Mon, Aug 26, 2019 at 4:02 PM Theodore Y. Ts'o <tytso@mit.edu> wrote:
> >
> > On Mon, Aug 26, 2019 at 02:35:33PM -0700, Doug Anderson wrote:
> > > * This requires extra tooling that I think nobody will adopt. People
> > > today already (accidentally) adopt Change-Id in the non-discardable
> > > portion. I think it would be easier to get everyone currently
> > > removing Change-Id to start including it again than it will be to get
> > > everyone to change their tools to move it to the discardable portion.
> >
> > The reason why people Change-Id's exist in commits today is because of
> > tooling which is distributed as part of Gerrit. That's why people are
> > deeply suspicious of any solution that involves Change-Id in the
> > non-discarded portion --- because the majority of Gerrit servers up
> > until now are behind corporate firewalls and since Gerrit servers have
> > robots.txt files, most Change-Id tend to be useless.
> >
> > If we come up with new tooling which is more useful, people will use
> > it. If it's not useful and doesn't makes life easier, people won't.
>
> Unfortunately the tooling won't come up until Change-Id is there and
> Change-Id can't be there till the tooling is there. ;-)
>
>
> > On Mon, Aug 26, 2019 at 03:06:43PM -0700, Doug Anderson wrote:
> > > 2. If, as I expect, Change-Id as part of the patch stays NAKed then I
> > > will modify the tools I use to post upstream (currently patman) to
> > > encode the Change-Id. My naive proposal would be:
> > >
> > > Message-Id: ChangeId-YYYY-MMDD-HHMMSS-PatchNum
> > >
> > > If I try this and it works for me then I will post out and suggest
> > > that any other like-minded people encode Change-Id into Message-Id in
> > > a similar way.
> >
> > ... and I would expect patches with this would get NACK'ed because
> > they would be just as useless as Change-Id's are perceived to be
> > today. People who are gaming the rules will tend not to looked upon
> > favorably; the same will apply to their patches.
>
> Sigh. Email is so hard to communicate over. I'm not intending to
> include the Message-Id in the commit. I'm intending to use the
> Change-Id _in_ the Message-Id. The Message-Id already has a bunch of
> random characters in it. Why not make them useful for something?
>
>
> > BTW, the Message-Id you've listed above is not legal, per RFC-5322. A
> > msg-id has to look like a e-mail address (left-hand-side@example.com).
> > So something like this is legal as a message id:
> >
> > I3268f9036512c4378cde1da37e0612b43ed4d384@linux-review.googlesource.com
>
> I think this is the same comment that Thomas Gleixner had. I will
> certainly make sure my Message-Ids are formed correctly. Thank you
> both for pointing this out to me. Presumably I would have noticed it
> when actually trying to implement this but now I definitely will.
>
>
> > ... and indeed, that's more useful, because it tells us how to
> > interpret I3268f9036512c4378cde1da37e0612b43ed4d384 --- it's a
> > Change-Id assigned by the linux-review.googlesource.com Gerrit server.
> >
> > In contrast a bare "I3268f9036512c4378cde1da37e0612b43ed4d384" is
> > going to be presumed to be useless. And in fact, a Google search for
> > this ID returns *nothing*. Yet visiting the link
> > https://linux-review.googlesource.com/c/1158 actually returns
> > something useful. That's why the latter is superior to the former.
>
> Sure, except that in my case there is no gerrit server to provide a
> link to. I use an upstream-first approach which means that all
> initial work is done with mailing lists. There is no server to
> provide context to. I think we are re-hashing old emails in this
> thread.
>
>
> > In summary,
> >
> > Not useful: (and will be probably nacked)
> >
> > Change-Id: I3268f9036512c4378cde1da37e0612b43ed4d384
> > Message-Id: I3268f9036512c4378cde1da37e0612b43ed4d384
> >
> > Useful:
> >
> > Link: https://linux-review.googlesource.com/c/1158
> > Link: https://lkml.kernel.org/r/20190826204407.17759-1-daniel.lezcano@linaro.org
> >
> > Not as useful: (people will prefer the Link example above)
> >
> > Message-Id: 20190826204407.17759-1-daniel.lezcano@linaro.org
>
> Presumably all the above is because you thought I was including the
> Message-Id in the commit. I'm not. Locally I will have Change-Id in
> my commit. The scripts I use to post to the mailing lists will strip
> the Change-Id out and use it to make the actual Message-Id. I will
Hm, I've spoken in favour of the Link: approach for upstream purposes.
But I do see the point in making it possible for people to somehow have
a workflow involving change-ids that does not interfer with regular
upstream expectations, i.e. no Change-Ids in commit messages.
One thing that came up was to place stuff like Change-Id after the ---
which git format-patch would leave out. This still has the problem
though that a git merge will keep the stuff after the --- and so a git
tag followed by a git request-pull would have the stuff in there as well
afaict. So I wonder if you couldn't simply enable Gerrit to look for
stuff like Change-Ids in git notes. They wouldn't show up on merges and
pulls afaict...
Christian
_______________________________________________
Ksummit-discuss mailing list
Ksummit-discuss@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/ksummit-discuss
next prev parent reply other threads:[~2019-09-16 14:11 UTC|newest]
Thread overview: 105+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-22 23:39 [Ksummit-discuss] Allowing something Change-Id (or something like it) in kernel commits Doug Anderson
2019-08-23 0:03 ` Brendan Higgins
2019-08-23 0:17 ` Linus Torvalds
2019-08-23 0:30 ` Olof Johansson
2019-08-23 0:43 ` Guenter Roeck
2019-08-23 0:45 ` Olof Johansson
2019-08-23 1:05 ` Olof Johansson
2019-08-23 1:09 ` Dmitry Torokhov
2019-08-23 1:36 ` Theodore Y. Ts'o
2019-08-23 2:58 ` Linus Torvalds
2019-08-23 3:03 ` Linus Torvalds
2019-08-23 13:15 ` Sean Paul
2019-08-23 15:18 ` Theodore Y. Ts'o
2019-08-23 15:31 ` Sean Paul
2019-08-23 15:48 ` Thomas Gleixner
2019-08-23 16:19 ` Dmitry Torokhov
2019-08-23 16:35 ` Joel Fernandes
2019-08-23 16:45 ` Doug Anderson
2019-08-23 16:54 ` Joel Fernandes
2019-08-23 18:00 ` Doug Anderson
2019-08-23 19:08 ` Joel Fernandes
2019-08-23 19:15 ` Joel Fernandes
2019-08-23 19:23 ` Thomas Gleixner
2019-08-23 19:31 ` Joel Fernandes
2019-08-24 16:53 ` Doug Anderson
2019-08-23 16:46 ` Dmitry Torokhov
2019-08-23 19:17 ` Thomas Gleixner
2019-08-23 19:38 ` Laurent Pinchart
2019-08-23 21:15 ` Thomas Gleixner
2019-08-23 21:25 ` Mark Brown
2019-08-24 23:13 ` Theodore Y. Ts'o
2019-08-25 7:09 ` Thomas Gleixner
2019-08-26 22:05 ` Thomas Gleixner
2019-08-28 8:50 ` Thomas Gleixner
2019-08-23 20:02 ` Christian Brauner
2019-08-24 16:34 ` Doug Anderson
2019-08-24 18:11 ` Linus Torvalds
2019-08-24 23:04 ` Theodore Y. Ts'o
2019-08-25 3:11 ` Greg Kroah-Hartman
2019-08-27 10:51 ` Mark Brown
2019-09-09 8:14 ` Michael Ellerman
2019-09-09 12:09 ` Mark Brown
2019-08-26 17:13 ` Doug Anderson
2019-08-26 17:30 ` Joel Fernandes
2019-08-26 21:35 ` Doug Anderson
2019-08-26 21:51 ` Thomas Gleixner
2019-08-26 22:06 ` Doug Anderson
2019-08-26 22:19 ` Thomas Gleixner
2019-08-26 23:02 ` Theodore Y. Ts'o
2019-08-26 23:11 ` Doug Anderson
2019-09-16 14:11 ` Christian Brauner [this message]
2019-09-16 17:43 ` Al Viro
2019-09-16 18:05 ` Doug Anderson
2019-08-26 23:43 ` Thomas Gleixner
2019-08-28 12:34 ` Christian Brauner
2019-08-27 0:29 ` Dmitry Vyukov
2019-08-27 6:06 ` Thomas Gleixner
2019-08-27 13:24 ` Dmitry Vyukov
2019-08-27 13:48 ` Greg Kroah-Hartman
2019-08-27 14:01 ` Guenter Roeck
2019-08-27 14:09 ` Thomas Gleixner
2019-08-27 15:33 ` Greg Kroah-Hartman
2019-08-27 15:42 ` Thomas Gleixner
2019-08-27 18:55 ` Konstantin Ryabitsev
2019-08-27 19:53 ` Greg Kroah-Hartman
2019-08-27 21:34 ` Joel Fernandes
2019-08-27 21:38 ` Joel Fernandes
2019-08-28 9:08 ` Greg Kroah-Hartman
2019-08-28 9:25 ` Jani Nikula
2019-08-28 10:04 ` Martin K. Petersen
2019-08-28 10:53 ` Thomas Gleixner
2019-08-28 12:46 ` Martin K. Petersen
2019-08-28 10:42 ` Mark Brown
2019-08-28 11:41 ` Greg Kroah-Hartman
2019-08-28 12:22 ` Christian Brauner
2019-08-28 12:38 ` Joel Fernandes
2019-08-28 13:58 ` Theodore Y. Ts'o
2019-08-28 20:39 ` Doug Anderson
2019-08-28 20:46 ` Johannes Berg
2019-08-28 21:00 ` Doug Anderson
2019-08-28 22:15 ` Rob Herring
2019-08-27 17:34 ` Geert Uytterhoeven
2019-08-27 18:50 ` Guenter Roeck
2019-08-27 14:06 ` Thomas Gleixner
2019-08-27 7:33 ` Geert Uytterhoeven
2019-08-27 13:30 ` Dmitry Vyukov
2019-08-27 14:28 ` Paul E. McKenney
2019-08-27 15:06 ` Thomas Gleixner
2019-08-27 15:25 ` Paul E. McKenney
2019-08-28 8:57 ` Dan Carpenter
2019-08-23 15:49 ` Doug Anderson
2019-08-23 15:54 ` Thomas Gleixner
2019-08-23 15:59 ` Thomas Gleixner
2019-08-23 16:38 ` Doug Anderson
2019-08-23 16:50 ` Andrew Lunn
2019-08-23 17:50 ` Doug Anderson
2019-08-23 18:10 ` Konstantin Ryabitsev
2019-08-26 22:19 ` Paul Mackerras
2019-08-27 7:02 ` Stephen Rothwell
2019-08-23 9:09 ` Vlastimil Babka
2019-08-23 12:48 ` Bhaskar Chowdhury
2019-08-23 1:01 ` Dmitry Torokhov
2019-08-23 1:07 ` Doug Anderson
2019-08-23 1:18 ` Joel Fernandes
2019-09-05 8:12 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190916141124.e7s3bjr4sp3bmtbp@wittgenstein \
--to=christian.brauner@ubuntu.com \
--cc=brho@google.com \
--cc=dianders@chromium.org \
--cc=dtor@chromium.org \
--cc=dvyukov@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=hanwen@google.com \
--cc=joelaf@google.com \
--cc=jrn@google.com \
--cc=ksummit-discuss@lists.linuxfoundation.org \
--cc=rientjes@google.com \
--cc=tfiga@chromium.org \
--cc=tytso@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).