kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] KVM: make: Fix out-of-source module builds
@ 2021-03-24 12:43 Siddharth Chandrasekaran
  2021-03-26 17:36 ` Paolo Bonzini
  0 siblings, 1 reply; 2+ messages in thread
From: Siddharth Chandrasekaran @ 2021-03-24 12:43 UTC (permalink / raw)
  To: Paolo Bonzini, Sean Christopherson, Vitaly Kuznetsov, Wanpeng Li,
	Jim Mattson, Joerg Roedel, Thomas Gleixner, Ingo Molnar,
	Borislav Petkov, x86, H. Peter Anvin
  Cc: Siddharth Chandrasekaran, kvm, linux-kernel

Building kvm module out-of-source with,

    make -C $SRC O=$BIN M=arch/x86/kvm

fails to find "irq.h" as the include dir passed to cflags-y does not
prefix the source dir. Fix this by prefixing $(srctree) to the include
dir path.

Signed-off-by: Siddharth Chandrasekaran <sidcha@amazon.de>
---
 arch/x86/kvm/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kvm/Makefile b/arch/x86/kvm/Makefile
index 1b4766fe1de2..eafc4d601f25 100644
--- a/arch/x86/kvm/Makefile
+++ b/arch/x86/kvm/Makefile
@@ -1,6 +1,6 @@
 # SPDX-License-Identifier: GPL-2.0
 
-ccflags-y += -Iarch/x86/kvm
+ccflags-y += -I $(srctree)/arch/x86/kvm
 ccflags-$(CONFIG_KVM_WERROR) += -Werror
 
 ifeq ($(CONFIG_FRAME_POINTER),y)
-- 
2.17.1




Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss
Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879




^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] KVM: make: Fix out-of-source module builds
  2021-03-24 12:43 [PATCH] KVM: make: Fix out-of-source module builds Siddharth Chandrasekaran
@ 2021-03-26 17:36 ` Paolo Bonzini
  0 siblings, 0 replies; 2+ messages in thread
From: Paolo Bonzini @ 2021-03-26 17:36 UTC (permalink / raw)
  To: Siddharth Chandrasekaran, Sean Christopherson, Vitaly Kuznetsov,
	Wanpeng Li, Jim Mattson, Joerg Roedel, Thomas Gleixner,
	Ingo Molnar, Borislav Petkov, x86, H. Peter Anvin
  Cc: kvm, linux-kernel

On 24/03/21 13:43, Siddharth Chandrasekaran wrote:
> Building kvm module out-of-source with,
> 
>      make -C $SRC O=$BIN M=arch/x86/kvm
> 
> fails to find "irq.h" as the include dir passed to cflags-y does not
> prefix the source dir. Fix this by prefixing $(srctree) to the include
> dir path.
> 
> Signed-off-by: Siddharth Chandrasekaran <sidcha@amazon.de>
> ---
>   arch/x86/kvm/Makefile | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kvm/Makefile b/arch/x86/kvm/Makefile
> index 1b4766fe1de2..eafc4d601f25 100644
> --- a/arch/x86/kvm/Makefile
> +++ b/arch/x86/kvm/Makefile
> @@ -1,6 +1,6 @@
>   # SPDX-License-Identifier: GPL-2.0
>   
> -ccflags-y += -Iarch/x86/kvm
> +ccflags-y += -I $(srctree)/arch/x86/kvm
>   ccflags-$(CONFIG_KVM_WERROR) += -Werror
>   
>   ifeq ($(CONFIG_FRAME_POINTER),y)
> 

Queued, thanks.

Paolo


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-03-26 17:36 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-24 12:43 [PATCH] KVM: make: Fix out-of-source module builds Siddharth Chandrasekaran
2021-03-26 17:36 ` Paolo Bonzini

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).