From: Steven Price <steven.price@arm.com>
To: linmiaohe <linmiaohe@huawei.com>,
"maz@kernel.org" <maz@kernel.org>,
"james.morse@arm.com" <james.morse@arm.com>,
"julien.thierry.kdev@gmail.com" <julien.thierry.kdev@gmail.com>,
"suzuki.poulose@arm.com" <suzuki.poulose@arm.com>,
"christoffer.dall@arm.com" <christoffer.dall@arm.com>,
"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
"eric.auger@redhat.com" <eric.auger@redhat.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"will@kernel.org" <will@kernel.org>,
"andre.przywara@arm.com" <andre.przywara@arm.com>,
"tglx@linutronix.de" <tglx@linutronix.de>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [PATCH] KVM: arm: get rid of unused arg in cpu_init_hyp_mode()
Date: Fri, 6 Dec 2019 10:10:53 +0000 [thread overview]
Message-ID: <11f06523-54ce-7025-a6ba-58c29769da60@arm.com> (raw)
In-Reply-To: <8efe4ab7f8c44c48a70378247c511edc@huawei.com>
On 30/11/2019 07:20, linmiaohe wrote:
>> From: Miaohe Lin <linmiaohe@huawei.com>
>>
>> As arg dummy is not really needed, there's no need to pass NULL when calling cpu_init_hyp_mode(). So clean it up.
It looks like the requirement for this dummy arg was removed in
67f691976662 ("arm64: kvm: allows kvm cpu hotplug"). FWIW:
Reviewed-by: Steven Price <steven.price@arm.com>
>> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
>> ---
>> virt/kvm/arm/arm.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/virt/kvm/arm/arm.c b/virt/kvm/arm/arm.c index 86c6aa1cb58e..a5470f1b1a19 100644
>> --- a/virt/kvm/arm/arm.c
>> +++ b/virt/kvm/arm/arm.c
>> @@ -1315,7 +1315,7 @@ long kvm_arch_vm_ioctl(struct file *filp,
>> }
>> }
>>
>> -static void cpu_init_hyp_mode(void *dummy)
>> +static void cpu_init_hyp_mode(void)
>> {
>> phys_addr_t pgd_ptr;
>> unsigned long hyp_stack_ptr;
>> @@ -1349,7 +1349,7 @@ static void cpu_hyp_reinit(void)
>> if (is_kernel_in_hyp_mode())
>> kvm_timer_init_vhe();
>> else
>> - cpu_init_hyp_mode(NULL);
>> + cpu_init_hyp_mode();
>>
>> kvm_arm_init_debug();
>>
> friendly ping ...
>
next prev parent reply other threads:[~2019-12-06 10:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-30 7:20 [PATCH] KVM: arm: get rid of unused arg in cpu_init_hyp_mode() linmiaohe
2019-12-06 10:10 ` Steven Price [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-11-21 7:15 linmiaohe
2019-12-06 11:43 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11f06523-54ce-7025-a6ba-58c29769da60@arm.com \
--to=steven.price@arm.com \
--cc=andre.przywara@arm.com \
--cc=catalin.marinas@arm.com \
--cc=christoffer.dall@arm.com \
--cc=eric.auger@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=james.morse@arm.com \
--cc=julien.thierry.kdev@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linmiaohe@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=suzuki.poulose@arm.com \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).