[PATCH] kvm: Fix wrong counting of MSI-X table size

[PATCH] kvm: Fix wrong counting of MSI-X table size

[Sheng Yang]

The PCI spec said...

System software reads this field to determine the MSI-X Table Size *N*,
which is encoded as *N-1*. For example, a returned value of “00000000011”
indicates a table size of 4.

Signed-off-by: Sheng Yang <sheng@linux.intel.com>
---
 qemu/hw/device-assignment.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/qemu/hw/device-assignment.c b/qemu/hw/device-assignment.c
index 09e54ae..f33ce3c 100644
--- a/qemu/hw/device-assignment.c
+++ b/qemu/hw/device-assignment.c
@@ -818,6 +818,7 @@ static int assigned_dev_update_msix_mmio(PCIDevice *pci_dev)
 
     entries_max_nr = pci_dev->config[pos + 2];
     entries_max_nr &= PCI_MSIX_TABSIZE;
+    entries_max_nr += 1;
 
     /* Get the usable entry number for allocating */
     for (i = 0; i < entries_max_nr; i++) {
-- 
1.5.4.5

Re: [PATCH] kvm: Fix wrong counting of MSI-X table size

[Avi Kivity]

Sheng Yang wrote:
> The PCI spec said...
>
> System software reads this field to determine the MSI-X Table Size *N*,
> which is encoded as *N-1*. For example, a returned value of “00000000011”
> indicates a table size of 4.
>
>   

Applied, thanks.

-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.