* [PATCH] KVM: VMX: remove unneeded 'asm volatile ("")' from vmcs_write64
@ 2019-06-02 19:11 Uros Bizjak
2019-06-04 17:22 ` Paolo Bonzini
0 siblings, 1 reply; 2+ messages in thread
From: Uros Bizjak @ 2019-06-02 19:11 UTC (permalink / raw)
To: kvm, pbonzini; +Cc: Uros Bizjak
__vmcs_writel uses volatile asm, so there is no need to insert another
one between the first and the second call to __vmcs_writel in order
to prevent unwanted code moves for 32bit targets.
Signed-off-by: Uros Bizjak <ubizjak@gmail.com>
---
arch/x86/kvm/vmx/ops.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/x86/kvm/vmx/ops.h b/arch/x86/kvm/vmx/ops.h
index b8e50f76fefc..2200fb698dd0 100644
--- a/arch/x86/kvm/vmx/ops.h
+++ b/arch/x86/kvm/vmx/ops.h
@@ -146,7 +146,6 @@ static __always_inline void vmcs_write64(unsigned long field, u64 value)
__vmcs_writel(field, value);
#ifndef CONFIG_X86_64
- asm volatile ("");
__vmcs_writel(field+1, value >> 32);
#endif
}
--
2.21.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] KVM: VMX: remove unneeded 'asm volatile ("")' from vmcs_write64
2019-06-02 19:11 [PATCH] KVM: VMX: remove unneeded 'asm volatile ("")' from vmcs_write64 Uros Bizjak
@ 2019-06-04 17:22 ` Paolo Bonzini
0 siblings, 0 replies; 2+ messages in thread
From: Paolo Bonzini @ 2019-06-04 17:22 UTC (permalink / raw)
To: Uros Bizjak, kvm
On 02/06/19 21:11, Uros Bizjak wrote:
> __vmcs_writel uses volatile asm, so there is no need to insert another
> one between the first and the second call to __vmcs_writel in order
> to prevent unwanted code moves for 32bit targets.
>
> Signed-off-by: Uros Bizjak <ubizjak@gmail.com>
> ---
> arch/x86/kvm/vmx/ops.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/x86/kvm/vmx/ops.h b/arch/x86/kvm/vmx/ops.h
> index b8e50f76fefc..2200fb698dd0 100644
> --- a/arch/x86/kvm/vmx/ops.h
> +++ b/arch/x86/kvm/vmx/ops.h
> @@ -146,7 +146,6 @@ static __always_inline void vmcs_write64(unsigned long field, u64 value)
>
> __vmcs_writel(field, value);
> #ifndef CONFIG_X86_64
> - asm volatile ("");
> __vmcs_writel(field+1, value >> 32);
> #endif
> }
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-04 17:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-02 19:11 [PATCH] KVM: VMX: remove unneeded 'asm volatile ("")' from vmcs_write64 Uros Bizjak
2019-06-04 17:22 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).