* [PATCH V3] kvm:x86 :remove unnecessary recalculate_apic_map
@ 2018-12-04 9:42 Peng Hao
2018-12-13 19:40 ` Radim Krčmář
0 siblings, 1 reply; 3+ messages in thread
From: Peng Hao @ 2018-12-04 9:42 UTC (permalink / raw)
To: tglx, pbonzini, rkrcmar; +Cc: x86, kvm, linux-kernel, Peng Hao
In the previous code, the variable apic_sw_disabled influences
recalculate_apic_map. But in "KVM: x86: simplify kvm_apic_map"
(commit:3b5a5ffa928a3f875b0d5dd284eeb7c322e1688a),
the access to apic_sw_disabled in recalculate_apic_map has been
deleted.
Signed-off-by: Peng Hao <peng.hao2@zte.com.cn>
---
arch/x86/kvm/lapic.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c
index fbb0e6d..a11fbf9 100644
--- a/arch/x86/kvm/lapic.c
+++ b/arch/x86/kvm/lapic.c
@@ -246,10 +246,9 @@ static inline void apic_set_spiv(struct kvm_lapic *apic, u32 val)
if (enabled != apic->sw_enabled) {
apic->sw_enabled = enabled;
- if (enabled) {
+ if (enabled)
static_key_slow_dec_deferred(&apic_sw_disabled);
- recalculate_apic_map(apic->vcpu->kvm);
- } else
+ else
static_key_slow_inc(&apic_sw_disabled.key);
}
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH V3] kvm:x86 :remove unnecessary recalculate_apic_map
2018-12-04 9:42 [PATCH V3] kvm:x86 :remove unnecessary recalculate_apic_map Peng Hao
@ 2018-12-13 19:40 ` Radim Krčmář
2018-12-14 10:27 ` Paolo Bonzini
0 siblings, 1 reply; 3+ messages in thread
From: Radim Krčmář @ 2018-12-13 19:40 UTC (permalink / raw)
To: Peng Hao; +Cc: tglx, pbonzini, x86, kvm, linux-kernel
2018-12-04 17:42+0800, Peng Hao:
> In the previous code, the variable apic_sw_disabled influences
> recalculate_apic_map. But in "KVM: x86: simplify kvm_apic_map"
> (commit:3b5a5ffa928a3f875b0d5dd284eeb7c322e1688a),
> the access to apic_sw_disabled in recalculate_apic_map has been
> deleted.
>
> Signed-off-by: Peng Hao <peng.hao2@zte.com.cn>
> ---
Reviewed-by: Radim Krčmář <rkrcmar@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH V3] kvm:x86 :remove unnecessary recalculate_apic_map
2018-12-13 19:40 ` Radim Krčmář
@ 2018-12-14 10:27 ` Paolo Bonzini
0 siblings, 0 replies; 3+ messages in thread
From: Paolo Bonzini @ 2018-12-14 10:27 UTC (permalink / raw)
To: Radim Krčmář, Peng Hao; +Cc: tglx, x86, kvm, linux-kernel
On 13/12/18 20:40, Radim Krčmář wrote:
> Reviewed-by: Radim Krčmář <rkrcmar@redhat.com>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-12-14 10:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-04 9:42 [PATCH V3] kvm:x86 :remove unnecessary recalculate_apic_map Peng Hao
2018-12-13 19:40 ` Radim Krčmář
2018-12-14 10:27 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).