* [PATCH kvm-unit-tests] x86: VMX: the "noclone" attribute is not needed
@ 2020-02-28 11:16 Paolo Bonzini
2020-03-01 20:58 ` Oliver Upton
0 siblings, 1 reply; 2+ messages in thread
From: Paolo Bonzini @ 2020-02-28 11:16 UTC (permalink / raw)
To: kvm; +Cc: morbo
Don't use the "noclone" attribute as it's not needed.
Also, clang does not support it.
Reported-by: Bill Wendling <morbo@google.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
x86/vmx_tests.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/x86/vmx_tests.c b/x86/vmx_tests.c
index a7abd63..e2fa034 100644
--- a/x86/vmx_tests.c
+++ b/x86/vmx_tests.c
@@ -4974,7 +4974,7 @@ extern unsigned char test_mtf1;
extern unsigned char test_mtf2;
extern unsigned char test_mtf3;
-__attribute__((noclone)) static void test_mtf_guest(void)
+static void test_mtf_guest(void)
{
asm ("vmcall;\n\t"
"out %al, $0x80;\n\t"
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH kvm-unit-tests] x86: VMX: the "noclone" attribute is not needed
2020-02-28 11:16 [PATCH kvm-unit-tests] x86: VMX: the "noclone" attribute is not needed Paolo Bonzini
@ 2020-03-01 20:58 ` Oliver Upton
0 siblings, 0 replies; 2+ messages in thread
From: Oliver Upton @ 2020-03-01 20:58 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: kvm list, Bill Wendling
On Fri, Feb 28, 2020 at 3:16 AM Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> Don't use the "noclone" attribute as it's not needed.
> Also, clang does not support it.
>
> Reported-by: Bill Wendling <morbo@google.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> x86/vmx_tests.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/x86/vmx_tests.c b/x86/vmx_tests.c
> index a7abd63..e2fa034 100644
> --- a/x86/vmx_tests.c
> +++ b/x86/vmx_tests.c
> @@ -4974,7 +4974,7 @@ extern unsigned char test_mtf1;
> extern unsigned char test_mtf2;
> extern unsigned char test_mtf3;
>
> -__attribute__((noclone)) static void test_mtf_guest(void)
> +static void test_mtf_guest(void)
> {
> asm ("vmcall;\n\t"
> "out %al, $0x80;\n\t"
> --
> 1.8.3.1
>
Reviewed-by: Oliver Upton <oupton@google.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-01 20:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-28 11:16 [PATCH kvm-unit-tests] x86: VMX: the "noclone" attribute is not needed Paolo Bonzini
2020-03-01 20:58 ` Oliver Upton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).