From: Dave Hansen <dave.hansen@intel.com>
To: Babu Moger <babu.moger@amd.com>,
corbet@lwn.net, tglx@linutronix.de, mingo@redhat.com,
bp@alien8.de, hpa@zytor.com, pbonzini@redhat.com,
sean.j.christopherson@intel.com
Cc: x86@kernel.org, vkuznets@redhat.com, wanpengli@tencent.com,
jmattson@google.com, joro@8bytes.org,
dave.hansen@linux.intel.com, luto@kernel.org,
peterz@infradead.org, mchehab+samsung@kernel.org,
changbin.du@intel.com, namit@vmware.com, bigeasy@linutronix.de,
yang.shi@linux.alibaba.com, asteinhauser@google.com,
anshuman.khandual@arm.com, jan.kiszka@siemens.com,
akpm@linux-foundation.org, steven.price@arm.com,
rppt@linux.vnet.ibm.com, peterx@redhat.com,
dan.j.williams@intel.com, arjunroy@google.com,
logang@deltatee.com, thellstrom@vmware.com, aarcange@redhat.com,
justin.he@arm.com, robin.murphy@arm.com, ira.weiny@intel.com,
keescook@chromium.org, jgross@suse.com,
andrew.cooper3@citrix.com, pawan.kumar.gupta@linux.intel.com,
fenghua.yu@intel.com, vineela.tummalapalli@intel.com,
yamada.masahiro@socionext.com, sam@ravnborg.org, acme@redhat.com,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org
Subject: Re: [PATCH v3 1/3] arch/x86: Rename config X86_INTEL_MEMORY_PROTECTION_KEYS to generic x86
Date: Tue, 12 May 2020 08:19:54 -0700 [thread overview]
Message-ID: <1f4fa674-5709-ad88-c7ae-1bf5584a5b82@intel.com> (raw)
In-Reply-To: <4984c0af-c20b-7084-9bca-5cb6bf385180@amd.com>
On 5/12/20 7:57 AM, Babu Moger wrote:
>> I was hoping to see at least *some* justification in this changelog. Do
>> you think having "INTEL_" will confuse users? Is there some technical
>> merit to this change?
>>
>> The naming churn is an obviously bad, not technically necessary change.
> Yes. Technically not necessary. But can cause some confusion on non-intel
> platforms.
Seriously, guys, this is buried deep in kernel code. Who is this confusing?
To me, this is like anything else we rename in the kernel. It causes
churn, which makes patches harder to backport for instance. That's why
we don't rename things willy-nilly when we just don't like the names.
The naming has to cause some practical, real-world problem that we *FIX*
with the rename.
I'm just asking for a concrete, practical problem statement in the
changelog. If there isn't one, then please don't do the rename. The
Kconfig magic is still fine since it fixes a practical problem for end
users.
next prev parent reply other threads:[~2020-05-12 15:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-11 23:32 [PATCH v3 0/3] arch/x86: Enable MPK feature on AMD Babu Moger
2020-05-11 23:32 ` [PATCH v3 1/3] arch/x86: Rename config X86_INTEL_MEMORY_PROTECTION_KEYS to generic x86 Babu Moger
2020-05-11 23:44 ` Dave Hansen
2020-05-12 14:57 ` Babu Moger
2020-05-12 15:19 ` Dave Hansen [this message]
2020-05-12 15:45 ` Babu Moger
2020-05-11 23:33 ` [PATCH v3 2/3] KVM: x86: Move pkru save/restore to x86.c Babu Moger
2020-05-12 16:39 ` Jim Mattson
2020-05-12 17:17 ` Babu Moger
2020-05-13 6:47 ` Paolo Bonzini
2020-05-11 23:33 ` [PATCH v3 3/3] KVM: x86: Move MPK feature detection to common code Babu Moger
2020-05-11 23:51 ` Jim Mattson
2020-05-12 15:12 ` Babu Moger
2020-05-12 16:58 ` Jim Mattson
2020-05-12 17:28 ` Sean Christopherson
2020-05-12 20:04 ` Babu Moger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f4fa674-5709-ad88-c7ae-1bf5584a5b82@intel.com \
--to=dave.hansen@intel.com \
--cc=aarcange@redhat.com \
--cc=acme@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=andrew.cooper3@citrix.com \
--cc=anshuman.khandual@arm.com \
--cc=arjunroy@google.com \
--cc=asteinhauser@google.com \
--cc=babu.moger@amd.com \
--cc=bigeasy@linutronix.de \
--cc=bp@alien8.de \
--cc=changbin.du@intel.com \
--cc=corbet@lwn.net \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=ira.weiny@intel.com \
--cc=jan.kiszka@siemens.com \
--cc=jgross@suse.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=justin.he@arm.com \
--cc=keescook@chromium.org \
--cc=kvm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=luto@kernel.org \
--cc=mchehab+samsung@kernel.org \
--cc=mingo@redhat.com \
--cc=namit@vmware.com \
--cc=pawan.kumar.gupta@linux.intel.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=peterz@infradead.org \
--cc=robin.murphy@arm.com \
--cc=rppt@linux.vnet.ibm.com \
--cc=sam@ravnborg.org \
--cc=sean.j.christopherson@intel.com \
--cc=steven.price@arm.com \
--cc=tglx@linutronix.de \
--cc=thellstrom@vmware.com \
--cc=vineela.tummalapalli@intel.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=x86@kernel.org \
--cc=yamada.masahiro@socionext.com \
--cc=yang.shi@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).