Re: [PATCH v3 3/3] KVM: x86: Move MPK feature detection to common code

From: Sean Christopherson <sean.j.christopherson@intel.com>
To: Jim Mattson <jmattson@google.com>
Cc: Babu Moger <babu.moger@amd.com>, Jonathan Corbet <corbet@lwn.net>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	"H . Peter Anvin" <hpa@zytor.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	the arch/x86 maintainers <x86@kernel.org>,
	Vitaly Kuznetsov <vkuznets@redhat.com>,
	Wanpeng Li <wanpengli@tencent.com>,
	Joerg Roedel <joro@8bytes.org>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Andy Lutomirski <luto@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	mchehab+samsung@kernel.org, changbin.du@intel.com,
	Nadav Amit <namit@vmware.com>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	yang.shi@linux.alibaba.com,
	Anthony Steinhauser <asteinhauser@google.com>,
	anshuman.khandual@arm.com, Jan Kiszka <jan.kiszka@siemens.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	steven.price@arm.com, rppt@linux.vnet.ibm.com, peterx@redhat.com,
	Dan Williams <dan.j.williams@intel.com>,
	Arjun Roy <arjunroy@google.com>,
	logang@deltatee.com, Thomas Hellstrom <thellstrom@vmware.com>,
	Andrea Arcangeli <aarcange@redhat.com>,
	justin.he@arm.com, robin.murphy@arm.com, ira.weiny@intel.com,
	Kees Cook <keescook@chromium.org>,
	Juergen Gross <jgross@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	pawan.kumar.gupta@linux.intel.com, "Yu,
	Fenghua" <fenghua.yu@intel.com>,
	vineela.tummalapalli@intel.com, yamada.masahiro@socionext.com,
	sam@ravnborg.org, acme@redhat.com, linux-doc@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>,
	kvm list <kvm@vger.kernel.org>
Subject: Re: [PATCH v3 3/3] KVM: x86: Move MPK feature detection to common code
Date: Tue, 12 May 2020 10:28:01 -0700	[thread overview]
Message-ID: <20200512172800.GB12100@linux.intel.com> (raw)
In-Reply-To: <CALMp9eRT69LWGE8dZVuLv2mxgc_R3W1SnPswHkhS8K0ZUX_B-Q@mail.gmail.com>

On Tue, May 12, 2020 at 09:58:19AM -0700, Jim Mattson wrote:
> On Tue, May 12, 2020 at 8:12 AM Babu Moger <babu.moger@amd.com> wrote:
> >
> >
> >
> > On 5/11/20 6:51 PM, Jim Mattson wrote:
> > > On Mon, May 11, 2020 at 4:33 PM Babu Moger <babu.moger@amd.com> wrote:
> > >>
> > >> Both Intel and AMD support (MPK) Memory Protection Key feature.
> > >> Move the feature detection from VMX to the common code. It should
> > >> work for both the platforms now.
> > >>
> > >> Signed-off-by: Babu Moger <babu.moger@amd.com>
> > >> ---
> > >>  arch/x86/kvm/cpuid.c   |    4 +++-
> > >>  arch/x86/kvm/vmx/vmx.c |    4 ----
> > >>  2 files changed, 3 insertions(+), 5 deletions(-)
> > >>
> > >> diff --git a/arch/x86/kvm/cpuid.c b/arch/x86/kvm/cpuid.c
> > >> index 901cd1fdecd9..3da7d6ea7574 100644
> > >> --- a/arch/x86/kvm/cpuid.c
> > >> +++ b/arch/x86/kvm/cpuid.c
> > >> @@ -278,6 +278,8 @@ void kvm_set_cpu_caps(void)
> > >>  #ifdef CONFIG_X86_64
> > >>         unsigned int f_gbpages = F(GBPAGES);
> > >>         unsigned int f_lm = F(LM);
> > >> +       /* PKU is not yet implemented for shadow paging. */
> > >> +       unsigned int f_pku = tdp_enabled ? F(PKU) : 0;
> > >
> > > I think we still want to require that OSPKE be set on the host before
> > > exposing PKU to the guest.
> > >
> >
> > Ok I can add this check.
> >
> > +       unsigned int f_pku = tdp_enabled && F(OSPKE)? F(PKU) : 0;
> 
> That doesn't do what you think it does. F(OSPKE) is a non-zero
> constant, so that conjunct is always true.

My vote would be to omit f_pku and adjust the cap directly, e.g.

diff --git a/arch/x86/kvm/cpuid.c b/arch/x86/kvm/cpuid.c
index 6828be99b9083..998c902df9e57 100644
--- a/arch/x86/kvm/cpuid.c
+++ b/arch/x86/kvm/cpuid.c
@@ -326,7 +326,7 @@ void kvm_set_cpu_caps(void)
        );

        kvm_cpu_cap_mask(CPUID_7_ECX,
-               F(AVX512VBMI) | F(LA57) | 0 /*PKU*/ | 0 /*OSPKE*/ | F(RDPID) |
+               F(AVX512VBMI) | F(LA57) | F(PKU) | 0 /*OSPKE*/ | F(RDPID) |
                F(AVX512_VPOPCNTDQ) | F(UMIP) | F(AVX512_VBMI2) | F(GFNI) |
                F(VAES) | F(VPCLMULQDQ) | F(AVX512_VNNI) | F(AVX512_BITALG) |
                F(CLDEMOTE) | F(MOVDIRI) | F(MOVDIR64B) | 0 /*WAITPKG*/
@@ -334,6 +334,8 @@ void kvm_set_cpu_caps(void)
        /* Set LA57 based on hardware capability. */
        if (cpuid_ecx(7) & F(LA57))
                kvm_cpu_cap_set(X86_FEATURE_LA57);
+       if (!tdp_enabled || !boot_cpu_has(OSPKE))
+               kvm_cpu_cap_clear(X86_FEATURE_PKU);

        kvm_cpu_cap_mask(CPUID_7_EDX,
                F(AVX512_4VNNIW) | F(AVX512_4FMAPS) | F(SPEC_CTRL) |
