* [PATCH] x86/kvm: remove unused ack_notifier callbacks
@ 2021-11-17 7:16 Juergen Gross
2021-11-17 7:45 ` Paolo Bonzini
0 siblings, 1 reply; 2+ messages in thread
From: Juergen Gross @ 2021-11-17 7:16 UTC (permalink / raw)
To: kvm, x86, linux-kernel
Cc: Juergen Gross, Paolo Bonzini, Sean Christopherson,
Vitaly Kuznetsov, Wanpeng Li, Jim Mattson, Joerg Roedel,
Thomas Gleixner, Ingo Molnar, Borislav Petkov, Dave Hansen,
H. Peter Anvin
Commit f52447261bc8c2 ("KVM: irq ack notification") introduced an
ack_notifier() callback in struct kvm_pic and in struct kvm_ioapic
without using them anywhere. Remove those callbacks again.
Signed-off-by: Juergen Gross <jgross@suse.com>
---
arch/x86/kvm/ioapic.h | 1 -
arch/x86/kvm/irq.h | 1 -
2 files changed, 2 deletions(-)
diff --git a/arch/x86/kvm/ioapic.h b/arch/x86/kvm/ioapic.h
index 623a3c5afad7..5666c39d8df1 100644
--- a/arch/x86/kvm/ioapic.h
+++ b/arch/x86/kvm/ioapic.h
@@ -81,7 +81,6 @@ struct kvm_ioapic {
unsigned long irq_states[IOAPIC_NUM_PINS];
struct kvm_io_device dev;
struct kvm *kvm;
- void (*ack_notifier)(void *opaque, int irq);
spinlock_t lock;
struct rtc_status rtc_status;
struct delayed_work eoi_inject;
diff --git a/arch/x86/kvm/irq.h b/arch/x86/kvm/irq.h
index 650642b18d15..c2d7cfe82d00 100644
--- a/arch/x86/kvm/irq.h
+++ b/arch/x86/kvm/irq.h
@@ -56,7 +56,6 @@ struct kvm_pic {
struct kvm_io_device dev_master;
struct kvm_io_device dev_slave;
struct kvm_io_device dev_elcr;
- void (*ack_notifier)(void *opaque, int irq);
unsigned long irq_states[PIC_NUM_PINS];
};
--
2.26.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] x86/kvm: remove unused ack_notifier callbacks
2021-11-17 7:16 [PATCH] x86/kvm: remove unused ack_notifier callbacks Juergen Gross
@ 2021-11-17 7:45 ` Paolo Bonzini
0 siblings, 0 replies; 2+ messages in thread
From: Paolo Bonzini @ 2021-11-17 7:45 UTC (permalink / raw)
To: Juergen Gross, kvm, x86, linux-kernel
Cc: Sean Christopherson, Vitaly Kuznetsov, Wanpeng Li, Jim Mattson,
Joerg Roedel, Thomas Gleixner, Ingo Molnar, Borislav Petkov,
Dave Hansen, H. Peter Anvin
On 11/17/21 08:16, Juergen Gross wrote:
> Commit f52447261bc8c2 ("KVM: irq ack notification") introduced an
> ack_notifier() callback in struct kvm_pic and in struct kvm_ioapic
> without using them anywhere. Remove those callbacks again.
>
> Signed-off-by: Juergen Gross <jgross@suse.com>
> ---
> arch/x86/kvm/ioapic.h | 1 -
> arch/x86/kvm/irq.h | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/arch/x86/kvm/ioapic.h b/arch/x86/kvm/ioapic.h
> index 623a3c5afad7..5666c39d8df1 100644
> --- a/arch/x86/kvm/ioapic.h
> +++ b/arch/x86/kvm/ioapic.h
> @@ -81,7 +81,6 @@ struct kvm_ioapic {
> unsigned long irq_states[IOAPIC_NUM_PINS];
> struct kvm_io_device dev;
> struct kvm *kvm;
> - void (*ack_notifier)(void *opaque, int irq);
> spinlock_t lock;
> struct rtc_status rtc_status;
> struct delayed_work eoi_inject;
> diff --git a/arch/x86/kvm/irq.h b/arch/x86/kvm/irq.h
> index 650642b18d15..c2d7cfe82d00 100644
> --- a/arch/x86/kvm/irq.h
> +++ b/arch/x86/kvm/irq.h
> @@ -56,7 +56,6 @@ struct kvm_pic {
> struct kvm_io_device dev_master;
> struct kvm_io_device dev_slave;
> struct kvm_io_device dev_elcr;
> - void (*ack_notifier)(void *opaque, int irq);
> unsigned long irq_states[PIC_NUM_PINS];
> };
>
>
Nice. Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-17 7:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-17 7:16 [PATCH] x86/kvm: remove unused ack_notifier callbacks Juergen Gross
2021-11-17 7:45 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).