From: Ryan Harper <ryanh@us.ibm.com>
To: Michael Goldish <mgoldish@redhat.com>
Cc: Ryan Harper <ryanh@us.ibm.com>,
kvm@vger.kernel.org, Uri Lublin <uril@redhat.com>
Subject: Re: [PATCH] kvm-autotest: add object addressing in sample cfg
Date: Fri, 3 Apr 2009 07:52:15 -0500 [thread overview]
Message-ID: <20090403125215.GD20681@us.ibm.com> (raw)
In-Reply-To: <586625821.3887371238745874165.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com>
* Michael Goldish <mgoldish@redhat.com> [2009-04-03 03:04]:
>
> ----- "Ryan Harper" <ryanh@us.ibm.com> wrote:
>
> > The wiki documents[1] object addressing quite well, but we should
> > include it in the example config file as well.
> >
> > 1.
> > http://www.linux-kvm.org/page/KVM-Autotest/Parameters#Addressing_objects_.28VMs.2C_images.2C_NICs_etc.29
> >
> >
> > --
> > Ryan Harper
> > Software Engineer; Linux Technology Center
> > IBM Corp., Austin, Tx
> > ryanh@us.ibm.com
> >
> >
> > diffstat output:
> > kvm_tests.cfg.sample | 4 ++++
> > 1 files changed, 4 insertions(+)
> >
> > Signed-off-by: Ryan Harper <ryanh@us.ibm.com>
> > ---
> > diff --git a/client/tests/kvm_runtest_2/kvm_tests.cfg.sample
> > b/client/tests/kvm_runtest_2/kvm_tests.cfg.sample
> > index 5619fa8..64f8e4b 100644
> > --- a/client/tests/kvm_runtest_2/kvm_tests.cfg.sample
> > +++ b/client/tests/kvm_runtest_2/kvm_tests.cfg.sample
> > @@ -19,6 +19,10 @@ image_size = 10G
> > ssh_port = 22
> > display = vnc
> >
> > +# specify specific values for vm1 and nic1
> > +mem_vm1 = 256
> > +nic_model_nic1 = rtl8139
> > +
> > # Port redirections
> > redirs = ssh
> > guest_port_ssh = 22
>
> This may not be a good idea, because we'll end up using only rtl8139.
> Further down in the file we define virtio and e1000 variants. The e1000 one, for example,
> specifies 'nic_model = e1000'. So you'll get a dict that contains:
>
> nic_model_vm1 = rtl8139
> nic_model = e1000
>
> and the second statement will have no effect on vm1, because object specific statements
> take precedence over general ones, regardless of order (as mentioned in the wiki).
>
> Also, we'll end up always using mem = 256 (isn't that too little for some guests?).
Right, I meant it as an example of an override and object assignment. I
didn't mean to imply that it should be the new default.
--
Ryan Harper
Software Engineer; Linux Technology Center
IBM Corp., Austin, Tx
ryanh@us.ibm.com
next prev parent reply other threads:[~2009-04-03 12:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <320283963.3887341238745823106.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com>
2009-04-03 8:04 ` [PATCH] kvm-autotest: add object addressing in sample cfg Michael Goldish
2009-04-03 12:52 ` Ryan Harper [this message]
2009-04-03 0:38 Ryan Harper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090403125215.GD20681@us.ibm.com \
--to=ryanh@us.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=mgoldish@redhat.com \
--cc=uril@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).