* [kvm-unit-tests PATCH v2] x86: Restore VMCS state when test_tpr_threshold_values() is done
@ 2019-05-18 16:13 Nadav Amit
0 siblings, 0 replies; only message in thread
From: Nadav Amit @ 2019-05-18 16:13 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: kvm, rkrcmar, Nadav Amit, Krish Sadhukhan
The VMCS fields of APIC_VIRT_ADDR and TPR_THRESHOLD are modified by
test_tpr_threshold_values() but are not restored to their original
value. Save and restore them.
Cc: Krish Sadhukhan <krish.sadhukhan@oracle.com>
Signed-off-by: Nadav Amit <nadav.amit@gmail.com>
---
v1->v2: Fix commit log, which had the wrong function name [Krish]
---
x86/vmx_tests.c | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/x86/vmx_tests.c b/x86/vmx_tests.c
index 0ca5363..d0ce1af 100644
--- a/x86/vmx_tests.c
+++ b/x86/vmx_tests.c
@@ -4432,6 +4432,8 @@ static void test_tpr_threshold_values(void)
static void test_tpr_threshold(void)
{
u32 primary = vmcs_read(CPU_EXEC_CTRL0);
+ u64 apic_virt_addr = vmcs_read(APIC_VIRT_ADDR);
+ u64 threshold = vmcs_read(TPR_THRESHOLD);
void *virtual_apic_page;
if (!(ctrl_cpu_rev[0].clr & CPU_TPR_SHADOW))
@@ -4451,11 +4453,8 @@ static void test_tpr_threshold(void)
report_prefix_pop();
if (!((ctrl_cpu_rev[0].clr & CPU_SECONDARY) &&
- (ctrl_cpu_rev[1].clr & (CPU_VINTD | CPU_VIRT_APIC_ACCESSES)))) {
- vmcs_write(CPU_EXEC_CTRL0, primary);
- return;
- }
-
+ (ctrl_cpu_rev[1].clr & (CPU_VINTD | CPU_VIRT_APIC_ACCESSES))))
+ goto out;
u32 secondary = vmcs_read(CPU_EXEC_CTRL1);
if (ctrl_cpu_rev[1].clr & CPU_VINTD) {
@@ -4505,6 +4504,9 @@ static void test_tpr_threshold(void)
}
vmcs_write(CPU_EXEC_CTRL1, secondary);
+out:
+ vmcs_write(TPR_THRESHOLD, threshold);
+ vmcs_write(APIC_VIRT_ADDR, apic_virt_addr);
vmcs_write(CPU_EXEC_CTRL0, primary);
}
--
2.17.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2019-05-18 23:33 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-18 16:13 [kvm-unit-tests PATCH v2] x86: Restore VMCS state when test_tpr_threshold_values() is done Nadav Amit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).