* [kvm-unit-tests PATCH] x86: Fix SMP stacks
@ 2019-05-20 9:17 Nadav Amit
2019-06-06 12:25 ` Paolo Bonzini
0 siblings, 1 reply; 2+ messages in thread
From: Nadav Amit @ 2019-05-20 9:17 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: kvm, Nadav Amit
Avoid smashing the SMP stacks during boot as currently happens by
allocating sufficient space for them.
Signed-off-by: Nadav Amit <nadav.amit@gmail.com>
---
x86/cstart64.S | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/x86/cstart64.S b/x86/cstart64.S
index a4b55c5..71c3153 100644
--- a/x86/cstart64.S
+++ b/x86/cstart64.S
@@ -19,7 +19,7 @@ max_cpus = MAX_TEST_CPUS
.align 16
stacktop:
- . = . + 4096
+ . = . + 4096 * max_cpus
.align 16
ring0stacktop:
@@ -170,7 +170,7 @@ efer = 0xc0000080
mov %eax, %cr0
ret
-smp_stacktop: .long 0xa0000
+smp_stacktop: .long stacktop - 4096
.align 16
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [kvm-unit-tests PATCH] x86: Fix SMP stacks
2019-05-20 9:17 [kvm-unit-tests PATCH] x86: Fix SMP stacks Nadav Amit
@ 2019-06-06 12:25 ` Paolo Bonzini
0 siblings, 0 replies; 2+ messages in thread
From: Paolo Bonzini @ 2019-06-06 12:25 UTC (permalink / raw)
To: Nadav Amit; +Cc: kvm
On 20/05/19 11:17, Nadav Amit wrote:
> Avoid smashing the SMP stacks during boot as currently happens by
> allocating sufficient space for them.
>
> Signed-off-by: Nadav Amit <nadav.amit@gmail.com>
> ---
> x86/cstart64.S | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/x86/cstart64.S b/x86/cstart64.S
> index a4b55c5..71c3153 100644
> --- a/x86/cstart64.S
> +++ b/x86/cstart64.S
> @@ -19,7 +19,7 @@ max_cpus = MAX_TEST_CPUS
> .align 16
> stacktop:
>
> - . = . + 4096
> + . = . + 4096 * max_cpus
> .align 16
> ring0stacktop:
>
> @@ -170,7 +170,7 @@ efer = 0xc0000080
> mov %eax, %cr0
> ret
>
> -smp_stacktop: .long 0xa0000
> +smp_stacktop: .long stacktop - 4096
>
> .align 16
>
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-06 12:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-20 9:17 [kvm-unit-tests PATCH] x86: Fix SMP stacks Nadav Amit
2019-06-06 12:25 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).