From: Matthew Wilcox <willy@infradead.org>
To: "Longpeng(Mike)" <longpeng2@huawei.com>
Cc: mike.kravetz@oracle.com, akpm@linux-foundation.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
arei.gonglei@huawei.com, weidong.huang@huawei.com,
weifuqiang@huawei.com, kvm@vger.kernel.org
Subject: Re: [PATCH] mm/hugetlb: avoid get wrong ptep caused by race
Date: Tue, 18 Feb 2020 12:52:39 -0800 [thread overview]
Message-ID: <20200218205239.GE24185@bombadil.infradead.org> (raw)
In-Reply-To: <1582027825-112728-1-git-send-email-longpeng2@huawei.com>
On Tue, Feb 18, 2020 at 08:10:25PM +0800, Longpeng(Mike) wrote:
> {
> - pgd_t *pgd;
> - p4d_t *p4d;
> - pud_t *pud;
> - pmd_t *pmd;
> + pgd_t *pgdp;
> + p4d_t *p4dp;
> + pud_t *pudp, pud;
> + pmd_t *pmdp, pmd;
Renaming the variables as part of a fix is a really bad idea. It obscures
the actual fix and makes everybody's life harder. Plus, it's not even
renaming to follow the normal convention -- there are only two places
(migrate.c and gup.c) which follow this pattern in mm/ while there are
33 that do not.
next prev parent reply other threads:[~2020-02-18 20:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-18 12:10 [PATCH] mm/hugetlb: avoid get wrong ptep caused by race Longpeng(Mike)
2020-02-18 20:37 ` Sean Christopherson
2020-02-19 0:51 ` Mike Kravetz
2020-02-19 1:39 ` Longpeng (Mike)
2020-02-19 1:58 ` Sean Christopherson
2020-02-19 12:21 ` Longpeng (Mike)
2020-02-19 16:22 ` Sean Christopherson
2020-02-20 2:32 ` Longpeng (Mike)
2020-02-19 19:33 ` Mike Kravetz
2020-02-20 2:30 ` Longpeng (Mike)
2020-02-21 0:22 ` Mike Kravetz
2020-02-22 2:15 ` Longpeng (Mike)
2020-02-18 20:52 ` Matthew Wilcox [this message]
2020-02-19 2:09 ` Longpeng (Mike)
2020-02-19 3:49 ` Mike Kravetz
2020-02-19 12:52 ` Longpeng (Mike)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200218205239.GE24185@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=arei.gonglei@huawei.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=longpeng2@huawei.com \
--cc=mike.kravetz@oracle.com \
--cc=weidong.huang@huawei.com \
--cc=weifuqiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).