kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] KVM: fix Kconfig menu text for -Werror
@ 2020-03-04 10:42 Jason A. Donenfeld
  2020-03-04 19:07 ` Sean Christopherson
  0 siblings, 1 reply; 4+ messages in thread
From: Jason A. Donenfeld @ 2020-03-04 10:42 UTC (permalink / raw)
  To: pbonzini, kvm, linux-kernel; +Cc: Jason A. Donenfeld

This was evidently copy and pasted from the i915 driver, but the text
wasn't updated.

Fixes: 4f337faf1c55 ("KVM: allow disabling -Werror")
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
---
 arch/x86/kvm/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kvm/Kconfig b/arch/x86/kvm/Kconfig
index 1bb4927030af..29bd4dc3363e 100644
--- a/arch/x86/kvm/Kconfig
+++ b/arch/x86/kvm/Kconfig
@@ -68,7 +68,7 @@ config KVM_WERROR
 	depends on (X86_64 && !KASAN) || !COMPILE_TEST
 	depends on EXPERT
 	help
-	  Add -Werror to the build flags for (and only for) i915.ko.
+	  Add -Werror to the build flags for kvm.ko.
 
 	  If in doubt, say "N".
 
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] KVM: fix Kconfig menu text for -Werror
  2020-03-04 10:42 [PATCH] KVM: fix Kconfig menu text for -Werror Jason A. Donenfeld
@ 2020-03-04 19:07 ` Sean Christopherson
  2020-03-05  6:06   ` [PATCH v2] " Jason A. Donenfeld
  0 siblings, 1 reply; 4+ messages in thread
From: Sean Christopherson @ 2020-03-04 19:07 UTC (permalink / raw)
  To: Jason A. Donenfeld; +Cc: pbonzini, kvm, linux-kernel

On Wed, Mar 04, 2020 at 06:42:21PM +0800, Jason A. Donenfeld wrote:
> This was evidently copy and pasted from the i915 driver, but the text
> wasn't updated.
> 
> Fixes: 4f337faf1c55 ("KVM: allow disabling -Werror")
> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
> ---
>  arch/x86/kvm/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kvm/Kconfig b/arch/x86/kvm/Kconfig
> index 1bb4927030af..29bd4dc3363e 100644
> --- a/arch/x86/kvm/Kconfig
> +++ b/arch/x86/kvm/Kconfig
> @@ -68,7 +68,7 @@ config KVM_WERROR
>  	depends on (X86_64 && !KASAN) || !COMPILE_TEST
>  	depends on EXPERT
>  	help
> -	  Add -Werror to the build flags for (and only for) i915.ko.
> +	  Add -Werror to the build flags for kvm.ko.

The -Werror flag also gets used when compiling kvm-intel.ko and kvm-amd.ko
as separate modules, as well as when KVM is built into the kernel and there
is no kvm.ko.  Probably easiest to simply say "for KVM".

>  
>  	  If in doubt, say "N".
>  
> -- 
> 2.25.1
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH v2] KVM: fix Kconfig menu text for -Werror
  2020-03-04 19:07 ` Sean Christopherson
@ 2020-03-05  6:06   ` Jason A. Donenfeld
  2020-03-05 14:28     ` Paolo Bonzini
  0 siblings, 1 reply; 4+ messages in thread
From: Jason A. Donenfeld @ 2020-03-05  6:06 UTC (permalink / raw)
  To: pbonzini, kvm, linux-kernel, sean.j.christopherson; +Cc: Jason A. Donenfeld

This was evidently copy and pasted from the i915 driver, but the text
wasn't updated.

Fixes: 4f337faf1c55 ("KVM: allow disabling -Werror")
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
---
 arch/x86/kvm/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kvm/Kconfig b/arch/x86/kvm/Kconfig
index 1bb4927030af..9fea0757db92 100644
--- a/arch/x86/kvm/Kconfig
+++ b/arch/x86/kvm/Kconfig
@@ -68,7 +68,7 @@ config KVM_WERROR
 	depends on (X86_64 && !KASAN) || !COMPILE_TEST
 	depends on EXPERT
 	help
-	  Add -Werror to the build flags for (and only for) i915.ko.
+	  Add -Werror to the build flags for KVM.
 
 	  If in doubt, say "N".
 
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] KVM: fix Kconfig menu text for -Werror
  2020-03-05  6:06   ` [PATCH v2] " Jason A. Donenfeld
@ 2020-03-05 14:28     ` Paolo Bonzini
  0 siblings, 0 replies; 4+ messages in thread
From: Paolo Bonzini @ 2020-03-05 14:28 UTC (permalink / raw)
  To: Jason A. Donenfeld, kvm, linux-kernel, sean.j.christopherson

On 05/03/20 07:06, Jason A. Donenfeld wrote:
> This was evidently copy and pasted from the i915 driver, but the text
> wasn't updated.
> 
> Fixes: 4f337faf1c55 ("KVM: allow disabling -Werror")
> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
> ---
>  arch/x86/kvm/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kvm/Kconfig b/arch/x86/kvm/Kconfig
> index 1bb4927030af..9fea0757db92 100644
> --- a/arch/x86/kvm/Kconfig
> +++ b/arch/x86/kvm/Kconfig
> @@ -68,7 +68,7 @@ config KVM_WERROR
>  	depends on (X86_64 && !KASAN) || !COMPILE_TEST
>  	depends on EXPERT
>  	help
> -	  Add -Werror to the build flags for (and only for) i915.ko.
> +	  Add -Werror to the build flags for KVM.
>  
>  	  If in doubt, say "N".
>  
> 

Queued, thanks.

Paolo


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-03-05 14:28 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-04 10:42 [PATCH] KVM: fix Kconfig menu text for -Werror Jason A. Donenfeld
2020-03-04 19:07 ` Sean Christopherson
2020-03-05  6:06   ` [PATCH v2] " Jason A. Donenfeld
2020-03-05 14:28     ` Paolo Bonzini

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).