* [PATCH] KVM: SVM: Fix build error due to missing release_pages() include
@ 2020-04-11 16:09 Borislav Petkov
2020-04-15 14:53 ` Paolo Bonzini
0 siblings, 1 reply; 2+ messages in thread
From: Borislav Petkov @ 2020-04-11 16:09 UTC (permalink / raw)
To: Joerg Roedel, Paolo Bonzini; +Cc: KVM, LKML
From: Borislav Petkov <bp@suse.de>
Fix:
arch/x86/kvm/svm/sev.c: In function ‘sev_pin_memory’:
arch/x86/kvm/svm/sev.c:360:3: error: implicit declaration of function ‘release_pages’;\
did you mean ‘reclaim_pages’? [-Werror=implicit-function-declaration]
360 | release_pages(pages, npinned);
| ^~~~~~~~~~~~~
| reclaim_pages
because svm.c includes pagemap.h but the carved out sev.c needs it too.
Triggered by a randconfig build.
Fixes: eaf78265a4ab ("KVM: SVM: Move SEV code to separate file")
Signed-off-by: Borislav Petkov <bp@suse.de>
---
arch/x86/kvm/svm/sev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/x86/kvm/svm/sev.c b/arch/x86/kvm/svm/sev.c
index 0e3fc311d7da..0208ab2179d5 100644
--- a/arch/x86/kvm/svm/sev.c
+++ b/arch/x86/kvm/svm/sev.c
@@ -12,6 +12,7 @@
#include <linux/kernel.h>
#include <linux/highmem.h>
#include <linux/psp-sev.h>
+#include <linux/pagemap.h>
#include <linux/swap.h>
#include "x86.h"
--
2.21.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] KVM: SVM: Fix build error due to missing release_pages() include
2020-04-11 16:09 [PATCH] KVM: SVM: Fix build error due to missing release_pages() include Borislav Petkov
@ 2020-04-15 14:53 ` Paolo Bonzini
0 siblings, 0 replies; 2+ messages in thread
From: Paolo Bonzini @ 2020-04-15 14:53 UTC (permalink / raw)
To: Borislav Petkov, Joerg Roedel; +Cc: KVM, LKML
On 11/04/20 18:09, Borislav Petkov wrote:
> From: Borislav Petkov <bp@suse.de>
>
> Fix:
>
> arch/x86/kvm/svm/sev.c: In function ‘sev_pin_memory’:
> arch/x86/kvm/svm/sev.c:360:3: error: implicit declaration of function ‘release_pages’;\
> did you mean ‘reclaim_pages’? [-Werror=implicit-function-declaration]
> 360 | release_pages(pages, npinned);
> | ^~~~~~~~~~~~~
> | reclaim_pages
>
> because svm.c includes pagemap.h but the carved out sev.c needs it too.
> Triggered by a randconfig build.
>
> Fixes: eaf78265a4ab ("KVM: SVM: Move SEV code to separate file")
> Signed-off-by: Borislav Petkov <bp@suse.de>
> ---
> arch/x86/kvm/svm/sev.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/x86/kvm/svm/sev.c b/arch/x86/kvm/svm/sev.c
> index 0e3fc311d7da..0208ab2179d5 100644
> --- a/arch/x86/kvm/svm/sev.c
> +++ b/arch/x86/kvm/svm/sev.c
> @@ -12,6 +12,7 @@
> #include <linux/kernel.h>
> #include <linux/highmem.h>
> #include <linux/psp-sev.h>
> +#include <linux/pagemap.h>
> #include <linux/swap.h>
>
> #include "x86.h"
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-15 14:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-11 16:09 [PATCH] KVM: SVM: Fix build error due to missing release_pages() include Borislav Petkov
2020-04-15 14:53 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).