kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
To: David Hildenbrand <david@redhat.com>
Cc: kbuild-all@lists.01.org, kvm@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	netdev@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>,
	Pankaj Gupta <pankaj.gupta.linux@gmail.com>
Subject: [vhost:vhost 8/22] drivers/virtio/virtio_mem.c:1375:20: error: implicit declaration of function 'kzalloc'; did you mean 'vzalloc'?
Date: Tue, 5 May 2020 22:15:25 +0800	[thread overview]
Message-ID: <202005052221.83QerHmG%lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 3269 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost
head:   da1742791d8c0c0a8e5471f181549c4726a5c5f9
commit: 7527631e900d464ed2d533f799cb0da2b29cc6f0 [8/22] virtio-mem: Paravirtualized memory hotplug
config: x86_64-randconfig-b002-20200505 (attached as .config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce:
        git checkout 7527631e900d464ed2d533f799cb0da2b29cc6f0
        # save the attached .config to linux build tree
        make ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>

All error/warnings (new ones prefixed by >>):

   drivers/virtio/virtio_mem.c: In function 'virtio_mem_probe':
>> drivers/virtio/virtio_mem.c:1375:20: error: implicit declaration of function 'kzalloc'; did you mean 'vzalloc'? [-Werror=implicit-function-declaration]
     vdev->priv = vm = kzalloc(sizeof(*vm), GFP_KERNEL);
                       ^~~~~~~
                       vzalloc
>> drivers/virtio/virtio_mem.c:1375:18: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
     vdev->priv = vm = kzalloc(sizeof(*vm), GFP_KERNEL);
                     ^
>> drivers/virtio/virtio_mem.c:1419:2: error: implicit declaration of function 'kfree'; did you mean 'vfree'? [-Werror=implicit-function-declaration]
     kfree(vm);
     ^~~~~
     vfree
   cc1: some warnings being treated as errors

vim +1375 drivers/virtio/virtio_mem.c

  1369	
  1370	static int virtio_mem_probe(struct virtio_device *vdev)
  1371	{
  1372		struct virtio_mem *vm;
  1373		int rc = -EINVAL;
  1374	
> 1375		vdev->priv = vm = kzalloc(sizeof(*vm), GFP_KERNEL);
  1376		if (!vm)
  1377			return -ENOMEM;
  1378	
  1379		init_waitqueue_head(&vm->host_resp);
  1380		vm->vdev = vdev;
  1381		INIT_WORK(&vm->wq, virtio_mem_run_wq);
  1382		mutex_init(&vm->hotplug_mutex);
  1383		INIT_LIST_HEAD(&vm->next);
  1384		spin_lock_init(&vm->removal_lock);
  1385		hrtimer_init(&vm->retry_timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL);
  1386		vm->retry_timer.function = virtio_mem_timer_expired;
  1387	
  1388		/* register the virtqueue */
  1389		rc = virtio_mem_init_vq(vm);
  1390		if (rc)
  1391			goto out_free_vm;
  1392	
  1393		/* initialize the device by querying the config */
  1394		rc = virtio_mem_init(vm);
  1395		if (rc)
  1396			goto out_del_vq;
  1397	
  1398		/* register callbacks */
  1399		vm->memory_notifier.notifier_call = virtio_mem_memory_notifier_cb;
  1400		rc = register_memory_notifier(&vm->memory_notifier);
  1401		if (rc)
  1402			goto out_del_vq;
  1403		rc = register_virtio_mem_device(vm);
  1404		if (rc)
  1405			goto out_unreg_mem;
  1406	
  1407		virtio_device_ready(vdev);
  1408	
  1409		/* trigger a config update to start processing the requested_size */
  1410		atomic_set(&vm->config_changed, 1);
  1411		queue_work(system_freezable_wq, &vm->wq);
  1412	
  1413		return 0;
  1414	out_unreg_mem:
  1415		unregister_memory_notifier(&vm->memory_notifier);
  1416	out_del_vq:
  1417		vdev->config->del_vqs(vdev);
  1418	out_free_vm:
> 1419		kfree(vm);
  1420		vdev->priv = NULL;
  1421	
  1422		return rc;
  1423	}
  1424	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 29432 bytes --]

             reply	other threads:[~2020-05-05 14:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-05 14:15 kbuild test robot [this message]
2020-05-05 14:50 ` [vhost:vhost 8/22] drivers/virtio/virtio_mem.c:1375:20: error: implicit declaration of function 'kzalloc'; did you mean 'vzalloc'? David Hildenbrand
2020-05-05 15:44   ` Michael S. Tsirkin
2020-05-05 15:46     ` David Hildenbrand
2020-05-05 16:20       ` Michael S. Tsirkin
2020-05-05 16:22         ` David Hildenbrand
2020-05-05 16:30           ` Michael S. Tsirkin
2020-05-06 20:28           ` Michael S. Tsirkin
2020-05-06 20:32             ` David Hildenbrand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202005052221.83QerHmG%lkp@intel.com \
    --to=lkp@intel.com \
    --cc=david@redhat.com \
    --cc=kbuild-all@lists.01.org \
    --cc=kvm@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=pankaj.gupta.linux@gmail.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).